Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Sebastian Hesselbarth
On 08/13/13 09:11, Thomas Petazzoni wrote: On Mon, 12 Aug 2013 20:46:47 +0200, Sebastian Hesselbarth wrote: + port->clk = of_clk_get_by_name(child, NULL); + if (IS_ERR(port->clk)) { + dev_err(>dev, "PCIe%d.%d: cannot get clock\n", +

Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Thierry Reding
On Mon, Aug 12, 2013 at 08:46:47PM +0200, Sebastian Hesselbarth wrote: [...] > diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c [...] > @@ -897,6 +897,16 @@ static int __init mvebu_pcie_probe(struct > platform_device *pdev) > continue; >

Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Mon, 12 Aug 2013 20:46:47 +0200, Sebastian Hesselbarth wrote: > + port->clk = of_clk_get_by_name(child, NULL); > + if (IS_ERR(port->clk)) { > + dev_err(>dev, "PCIe%d.%d: cannot get clock\n", > +

Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Mon, 12 Aug 2013 20:46:47 +0200, Sebastian Hesselbarth wrote: + port-clk = of_clk_get_by_name(child, NULL); + if (IS_ERR(port-clk)) { + dev_err(pdev-dev, PCIe%d.%d: cannot get clock\n, +

Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Thierry Reding
On Mon, Aug 12, 2013 at 08:46:47PM +0200, Sebastian Hesselbarth wrote: [...] diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c [...] @@ -897,6 +897,16 @@ static int __init mvebu_pcie_probe(struct platform_device *pdev) continue; }

Re: [PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-13 Thread Sebastian Hesselbarth
On 08/13/13 09:11, Thomas Petazzoni wrote: On Mon, 12 Aug 2013 20:46:47 +0200, Sebastian Hesselbarth wrote: + port-clk = of_clk_get_by_name(child, NULL); + if (IS_ERR(port-clk)) { + dev_err(pdev-dev, PCIe%d.%d: cannot get clock\n, +

[PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-12 Thread Sebastian Hesselbarth
The clock passed to PCI controller found on MVEBU SoCs may come from a clock gate. This requires the clock to be enabled before any registers are accessed. Therefore, move the clock enable before register iomap to ensure it is enabled. Signed-off-by: Sebastian Hesselbarth --- Cc: Russell King

[PATCH 1/9] PCI: mvebu: move clock enable before register access

2013-08-12 Thread Sebastian Hesselbarth
The clock passed to PCI controller found on MVEBU SoCs may come from a clock gate. This requires the clock to be enabled before any registers are accessed. Therefore, move the clock enable before register iomap to ensure it is enabled. Signed-off-by: Sebastian Hesselbarth