Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-22 Thread Jeffrey Ellis
Best, J. On Nov 21, 2012, at 4:37 PM, Jan Kara wrote: > On Wed 21-11-12 13:29:01, Christoph Hellwig wrote: >> On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: I'd like to use this as a vehicle to revisit how dio completions work. >>> >>> I don't like the sound of that. ;-)

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-22 Thread Jan Kara
On Wed 21-11-12 13:29:01, Christoph Hellwig wrote: > On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: > > > I'd like to use this as a vehicle to revisit how dio completions work. > > > > I don't like the sound of that. ;-) It sounds like this bugfix may get > > further delayed by the

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-22 Thread Jan Kara
On Wed 21-11-12 13:29:01, Christoph Hellwig wrote: On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: I'd like to use this as a vehicle to revisit how dio completions work. I don't like the sound of that. ;-) It sounds like this bugfix may get further delayed by the desire

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-22 Thread Jeffrey Ellis
Best, J. On Nov 21, 2012, at 4:37 PM, Jan Kara j...@suse.cz wrote: On Wed 21-11-12 13:29:01, Christoph Hellwig wrote: On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: I'd like to use this as a vehicle to revisit how dio completions work. I don't like the sound of that. ;-)

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Jeff Moyer
Christoph Hellwig writes: > On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: >> > I'd like to use this as a vehicle to revisit how dio completions work. >> >> I don't like the sound of that. ;-) It sounds like this bugfix may get >> further delayed by the desire for unrelated code

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: > > I'd like to use this as a vehicle to revisit how dio completions work. > > I don't like the sound of that. ;-) It sounds like this bugfix may get > further delayed by the desire for unrelated code cleanup. I've got a prototype

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Jeff Moyer
Christoph Hellwig writes: > On Mon, Nov 19, 2012 at 11:41:23PM -0800, Darrick J. Wong wrote: >> Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting >> to >> use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the >> filesystem doesn't provide its

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Christoph Hellwig
On Mon, Nov 19, 2012 at 11:41:23PM -0800, Darrick J. Wong wrote: > Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting > to > use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the > filesystem doesn't provide its own direct IO end_io handler, the

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Christoph Hellwig
On Mon, Nov 19, 2012 at 11:41:23PM -0800, Darrick J. Wong wrote: Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting to use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the filesystem doesn't provide its own direct IO end_io handler, the

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Jeff Moyer
Christoph Hellwig h...@infradead.org writes: On Mon, Nov 19, 2012 at 11:41:23PM -0800, Darrick J. Wong wrote: Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting to use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the filesystem doesn't

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: I'd like to use this as a vehicle to revisit how dio completions work. I don't like the sound of that. ;-) It sounds like this bugfix may get further delayed by the desire for unrelated code cleanup. I've got a prototype that

Re: [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-21 Thread Jeff Moyer
Christoph Hellwig h...@infradead.org writes: On Wed, Nov 21, 2012 at 11:58:05AM -0500, Jeff Moyer wrote: I'd like to use this as a vehicle to revisit how dio completions work. I don't like the sound of that. ;-) It sounds like this bugfix may get further delayed by the desire for

[PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-19 Thread Darrick J. Wong
Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting to use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the filesystem doesn't provide its own direct IO end_io handler, the generic code will take care of issuing the flush. Otherwise, the

[PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-11-19 Thread Darrick J. Wong
Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystems wanting to use the helpers have to pass DIO_SYNC_WRITES to __blockdev_direct_IO. If the filesystem doesn't provide its own direct IO end_io handler, the generic code will take care of issuing the flush. Otherwise, the