Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-17 Thread Mark Brown
On Mon, Feb 17, 2014 at 04:15:41PM +0900, Milo Kim wrote: > Thank you. I've fixed things based on your comments. > Could you check the description below? > I'd like to get your feedback before sending patch-set v2. Yes, this looks OK. signature.asc Description: Digital signature

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-17 Thread Mark Brown
On Mon, Feb 17, 2014 at 04:15:41PM +0900, Milo Kim wrote: Thank you. I've fixed things based on your comments. Could you check the description below? I'd like to get your feedback before sending patch-set v2. Yes, this looks OK. signature.asc Description: Digital signature

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hi Mark, On 02/15/2014 05:50 AM, Mark Brown wrote: On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Ah, sorry - I didn't notice that there were several different binding documents in the patch. @@ -0,0

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hello Mark, Thanks for your detailed comments. I've fixed the structure and description. I'd like to have your feedback before submitting new patch-set. From 33faeeed69fa064cd476b252c5a7326a541e12b3 Mon Sep 17 00:00:00 2001 From: Milo Kim Date: Mon, 17 Feb 2014 14:32:39 +0900 Subject: [PATCH

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hi Mark, On 02/15/2014 05:50 AM, Mark Brown wrote: On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Ah, sorry - I didn't notice that there were several different binding documents in the patch. @@ -0,0

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-16 Thread Milo Kim
Hello Mark, Thanks for your detailed comments. I've fixed the structure and description. I'd like to have your feedback before submitting new patch-set. From 33faeeed69fa064cd476b252c5a7326a541e12b3 Mon Sep 17 00:00:00 2001 From: Milo Kim milo@ti.com Date: Mon, 17 Feb 2014 14:32:39 +0900

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: > Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Ah, sorry - I didn't notice that there were several different binding documents in the patch. > @@ -0,0 +1,49 @@ > +TI LMU LM3631 regulator device tree bindings

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: > Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. I don't see actual documentation for the regulators here? They're there in the examples but not in the binding section. signature.asc Description: Digital

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. I don't see actual documentation for the regulators here? They're there in the examples but not in the binding section. signature.asc Description: Digital

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-15 Thread Mark Brown
On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Ah, sorry - I didn't notice that there were several different binding documents in the patch. @@ -0,0 +1,49 @@ +TI LMU LM3631 regulator device tree bindings +

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-14 Thread Mark Rutland
On Fri, Feb 14, 2014 at 06:32:44AM +, Milo Kim wrote: > Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. > > Cc: devicet...@vger.kernel.org > Cc: Bryan Wu > Cc: Jingoo Han > Cc: Lee Jones > Cc: Mark Brown > Cc: Samuel Ortiz > Signed-off-by: Milo Kim > --- >

Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-14 Thread Mark Rutland
On Fri, Feb 14, 2014 at 06:32:44AM +, Milo Kim wrote: Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Cc: devicet...@vger.kernel.org Cc: Bryan Wu coolo...@gmail.com Cc: Jingoo Han jg1@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Mark Brown

[PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-13 Thread Milo Kim
Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Cc: devicet...@vger.kernel.org Cc: Bryan Wu Cc: Jingoo Han Cc: Lee Jones Cc: Mark Brown Cc: Samuel Ortiz Signed-off-by: Milo Kim --- .../devicetree/bindings/leds/leds-lm3633.txt | 39 +

[PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices

2014-02-13 Thread Milo Kim
Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added. Cc: devicet...@vger.kernel.org Cc: Bryan Wu coolo...@gmail.com Cc: Jingoo Han jg1@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Mark Brown broo...@kernel.org Cc: Samuel Ortiz sa...@linux.intel.com Signed-off-by: