Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

2008-02-14 Thread Alan Cox
On Wed, 13 Feb 2008 21:14:32 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Let's use ld for legacy_data instead of shadowing these static > int variables. NAK - I purposefully used names that indicate what device the private data is being used for in order to make it clear. Changing qdi and

Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

2008-02-14 Thread Alan Cox
On Wed, 13 Feb 2008 21:14:32 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: Let's use ld for legacy_data instead of shadowing these static int variables. NAK - I purposefully used names that indicate what device the private data is being used for in order to make it clear. Changing qdi and

[PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

2008-02-13 Thread Harvey Harrison
Let's use ld for legacy_data instead of shadowing these static int variables. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one

[PATCH 11/11] ata: fix sparse warnings in pata_legacy.c

2008-02-13 Thread Harvey Harrison
Let's use ld for legacy_data instead of shadowing these static int variables. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one