Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Namhyung Kim
Hi Arnaldo, On Tue, 4 Dec 2012 10:50:49 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 04, 2012 at 06:16:59PM +0900, Namhyung Kim escreveu: >> On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo wrote: > >> Ah, I missed your point. Just got it now, will try this approach. So >> you

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 04, 2012 at 06:16:59PM +0900, Namhyung Kim escreveu: > On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo wrote: > Ah, I missed your point. Just got it now, will try this approach. So > you want to see no "0.00%" for a dummy entry, right? That wasn't the point, and perhaps

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Namhyung Kim
On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: >> On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: >> > +#define __HPP_COLOR_PERCENT_FN(_type, _field) >> > \ >> >

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Namhyung Kim
On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo a...@ghostprotocols.net wrote: Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: +#define __HPP_COLOR_PERCENT_FN(_type, _field)

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 04, 2012 at 06:16:59PM +0900, Namhyung Kim escreveu: On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo wrote: Ah, I missed your point. Just got it now, will try this approach. So you want to see no 0.00% for a dummy entry, right? That wasn't the point, and perhaps

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-04 Thread Namhyung Kim
Hi Arnaldo, On Tue, 4 Dec 2012 10:50:49 -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 04, 2012 at 06:16:59PM +0900, Namhyung Kim escreveu: On Fri, Nov 30, 2012 at 10:52 PM, Arnaldo Carvalho de Melo wrote: Ah, I missed your point. Just got it now, will try this approach. So you want to

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 16:57:36 +0100, Jiri Olsa wrote: > On Mon, Dec 03, 2012 at 07:39:31PM +0900, Namhyung Kim wrote: >> On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: >> > On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: >> >> On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa wrote: >>

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 07:39:31PM +0900, Namhyung Kim wrote: > On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: > > On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: > >> On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa wrote: > >> > ok, so this is the part thats common for both multi

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: > On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: >> On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa wrote: >> > ok, so this is the part thats common for both multi diff and group >> > report and hugely depends on how we link matching

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa wrote: > > On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: > > > > SNIP > > > >> +#define __HPP_COLOR_PERCENT_FN(_type, _field) > >>

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: Hi Jiri, On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa jo...@redhat.com wrote: On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: SNIP +#define __HPP_COLOR_PERCENT_FN(_type, _field)

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa jo...@redhat.com wrote: ok, so this is the part thats common for both multi diff and group report and hugely depends on how we link

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Jiri Olsa
On Mon, Dec 03, 2012 at 07:39:31PM +0900, Namhyung Kim wrote: On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa jo...@redhat.com wrote: ok, so this is the part thats common for both

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-03 Thread Namhyung Kim
On Mon, 3 Dec 2012 16:57:36 +0100, Jiri Olsa wrote: On Mon, Dec 03, 2012 at 07:39:31PM +0900, Namhyung Kim wrote: On Mon, 3 Dec 2012 11:23:27 +0100, Jiri Olsa wrote: On Mon, Dec 03, 2012 at 10:56:28AM +0900, Namhyung Kim wrote: On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa jo...@redhat.com

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-02 Thread Namhyung Kim
Hi Jiri, On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa wrote: > On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: > > SNIP > >> +#define __HPP_COLOR_PERCENT_FN(_type, _field) >> \ >> +static int hpp__color_##_type(struct perf_hpp *hpp, struct

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-02 Thread Namhyung Kim
On Fri, 30 Nov 2012 10:52:15 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: >> On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: >> > +#define __HPP_COLOR_PERCENT_FN(_type, _field) >> > \ >> >

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-02 Thread Namhyung Kim
On Fri, 30 Nov 2012 10:52:15 -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: +#define __HPP_COLOR_PERCENT_FN(_type, _field) \ +static int

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-12-02 Thread Namhyung Kim
Hi Jiri, On Fri, Nov 30, 2012 at 10:29 PM, Jiri Olsa jo...@redhat.com wrote: On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: SNIP +#define __HPP_COLOR_PERCENT_FN(_type, _field) \ +static int hpp__color_##_type(struct perf_hpp *hpp,

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-11-30 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: > On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: > > +#define __HPP_COLOR_PERCENT_FN(_type, _field) > > \ > > +static int hpp__color_##_type(struct perf_hpp *hpp, struct hist_entry

Re: [PATCH 12/18] perf ui/hist: Add support for event group view

2012-11-30 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 30, 2012 at 02:29:43PM +0100, Jiri Olsa escreveu: On Thu, Nov 29, 2012 at 03:38:40PM +0900, Namhyung Kim wrote: +#define __HPP_COLOR_PERCENT_FN(_type, _field) \ +static int hpp__color_##_type(struct perf_hpp *hpp, struct hist_entry *he)

[PATCH 12/18] perf ui/hist: Add support for event group view

2012-11-28 Thread Namhyung Kim
From: Namhyung Kim Show group members' overhead also when showing the leader's if event group is enabled. Use macro for defining hpp functions which looks almost identical. Cc: Jiri Olsa Cc: Stephane Eranian Signed-off-by: Namhyung Kim --- tools/perf/ui/hist.c | 370

[PATCH 12/18] perf ui/hist: Add support for event group view

2012-11-28 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Show group members' overhead also when showing the leader's if event group is enabled. Use macro for defining hpp functions which looks almost identical. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Signed-off-by: Namhyung Kim