Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-22 Thread Namhyung Kim
On Thu, Oct 22, 2015 at 5:46 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> > 5) --no-children >> > >> > I agree that 'perf top -g --no-children' looks more intuitive than 'perf >> > top -g'. >> >> So, what do you propose, to switch back the default to --no-children, for >>

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-22 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > > 5) --no-children > > > > I agree that 'perf top -g --no-children' looks more intuitive than 'perf > > top -g'. > > So, what do you propose, to switch back the default to --no-children, for > both > tools, top and report? Now that I am getting used to

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-22 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > > 5) --no-children > > > > I agree that 'perf top -g --no-children' looks more intuitive than 'perf > > top -g'. > > So, what do you propose, to switch back the default to --no-children, for > both > tools, top and report? Now that I am

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-22 Thread Namhyung Kim
On Thu, Oct 22, 2015 at 5:46 PM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> > 5) --no-children >> > >> > I agree that 'perf top -g --no-children' looks more intuitive than 'perf >> > top -g'. >> >> So, what do you propose, to switch back the

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Wed, Oct 21, 2015 at 12:23 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 21, 2015 at 11:28:54AM -0700, Brendan Gregg escreveu: >> On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth >> wrote: >> > Since Arnaldo asked, I thought I should actually try to respond >> > specifically >> > to

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 11:28:54AM -0700, Brendan Gregg escreveu: > On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth wrote: > > Since Arnaldo asked, I thought I should actually try to respond specifically > > to the question of why I favor the 'caller' view as the default. > > > > On Tue, Oct

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Wed, Oct 21, 2015 at 1:06 AM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Indeed, finding a default that is deemed adequate for most people is, ho-hum, >> difficult 8-) >> >> Ingo, what do you think? > > So I think the new default is a lot more intuitive, because it starts

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth wrote: > Since Arnaldo asked, I thought I should actually try to respond specifically > to the question of why I favor the 'caller' view as the default. > > On Tue, Oct 20, 2015 at 3:06 AM Arnaldo Carvalho de Melo > wrote: >> >> > IMHO changing

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Frederic Weisbecker
On Wed, Oct 21, 2015 at 05:09:08PM +0900, Namhyung Kim wrote: > On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: > > Well, I would prefer to hear from regular users than random twitter > > followers. > > I could be wrong so lets ask some users first. > > Just a question. Do

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Frederic Weisbecker
On Wed, Oct 21, 2015 at 02:21:12AM +, Chandler Carruth wrote: > On Tue, Oct 20, 2015 at 3:06 AM Arnaldo Carvalho de Melo < > arnaldo.m...@gmail.com> wrote: > > > > IMHO changing that order is not a good idea. Unless many users complained > > > about it. > > > > Perhaps there are not that many

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:43:48AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 21, 2015 at 10:48:16AM +0200, Ingo Molnar escreveu: > > 5) --no-children > > > > I agree that 'perf top -g --no-children' looks more intuitive than 'perf > > top -g'. > > So, what do you propose, to

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:48:16AM +0200, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > I was bitten by the --children thing and took some time to get used to it, > > so I > > can relate to that... > > > > I think we should revert this change in callchain default, enough

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:21:36AM +0900, Namhyung Kim escreveu: > On Tue, Oct 20, 2015 at 03:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:06:45AM +0200, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > Indeed, finding a default that is deemed adequate for most people is, > > ho-hum, > > difficult 8-) > > Ingo, what do you think? > So I think the new default is a lot more intuitive,

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Wangnan (F)
On 2015/10/21 16:09, Namhyung Kim wrote: Hi Frederic, On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: On Tue, Oct 20, 2015

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > I was bitten by the --children thing and took some time to get used to it, so > I > can relate to that... > > I think we should revert this change in callchain default, enough > complaints... > Ingo, since you suggested that change, what are your

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Namhyung Kim
Hi Frederic, On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Indeed, finding a default that is deemed adequate for most people is, ho-hum, > difficult 8-) > > Ingo, what do you think? So I think the new default is a lot more intuitive, because it starts with a high level top-down 'overview' kind of output,

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Namhyung Kim
Hi Brendan, On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote: > On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim wrote: > > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > >> From: Arnaldo Carvalho de Melo > >> > >> Which is the most common default found in

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:43:48AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 21, 2015 at 10:48:16AM +0200, Ingo Molnar escreveu: > > 5) --no-children > > > > I agree that 'perf top -g --no-children' looks more intuitive than 'perf > > top -g'. > > So, what do you propose, to

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:48:16AM +0200, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > I was bitten by the --children thing and took some time to get used to it, > > so I > > can relate to that... > > > > I think we should revert this change in callchain

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Frederic Weisbecker
On Wed, Oct 21, 2015 at 05:09:08PM +0900, Namhyung Kim wrote: > On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: > > Well, I would prefer to hear from regular users than random twitter > > followers. > > I could be wrong so lets ask some users first. > > Just a question. Do

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Frederic Weisbecker
On Wed, Oct 21, 2015 at 02:21:12AM +, Chandler Carruth wrote: > On Tue, Oct 20, 2015 at 3:06 AM Arnaldo Carvalho de Melo < > arnaldo.m...@gmail.com> wrote: > > > > IMHO changing that order is not a good idea. Unless many users complained > > > about it. > > > > Perhaps there are not that many

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth wrote: > Since Arnaldo asked, I thought I should actually try to respond specifically > to the question of why I favor the 'caller' view as the default. > > On Tue, Oct 20, 2015 at 3:06 AM Arnaldo Carvalho de Melo >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 11:28:54AM -0700, Brendan Gregg escreveu: > On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth wrote: > > Since Arnaldo asked, I thought I should actually try to respond specifically > > to the question of why I favor the 'caller' view as the default. >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Wed, Oct 21, 2015 at 1:06 AM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Indeed, finding a default that is deemed adequate for most people is, ho-hum, >> difficult 8-) >> >> Ingo, what do you think? > > So I think the new default is

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Brendan Gregg
On Wed, Oct 21, 2015 at 12:23 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 21, 2015 at 11:28:54AM -0700, Brendan Gregg escreveu: >> On Tue, Oct 20, 2015 at 7:21 PM, Chandler Carruth >> wrote: >> > Since Arnaldo asked, I thought I should actually

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:06:45AM +0200, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > Indeed, finding a default that is deemed adequate for most people is, > > ho-hum, > > difficult 8-) > > Ingo, what do you think? > So I think the new default is a

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2015 at 10:21:36AM +0900, Namhyung Kim escreveu: > On Tue, Oct 20, 2015 at 03:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Wangnan (F)
On 2015/10/21 16:09, Namhyung Kim wrote: Hi Frederic, On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: On Tue, Oct 20, 2015

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Indeed, finding a default that is deemed adequate for most people is, ho-hum, > difficult 8-) > > Ingo, what do you think? So I think the new default is a lot more intuitive, because it starts with a high level top-down 'overview'

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Namhyung Kim
Hi Brendan, On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote: > On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim wrote: > > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > >> From: Arnaldo Carvalho de Melo > >> > >>

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Namhyung Kim
Hi Frederic, On Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker wrote: > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-21 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > I was bitten by the --children thing and took some time to get used to it, so > I > can relate to that... > > I think we should revert this change in callchain default, enough > complaints... > Ingo, since you suggested that change,

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Namhyung Kim
On Tue, Oct 20, 2015 at 11:38:16AM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 09:23:12PM +0800, Wangnan (F) escreveu: > > On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: > > >From: Arnaldo Carvalho de Melo > > >Which is the most common default found in other similar

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Namhyung Kim
Hi Arnaldo, On Tue, Oct 20, 2015 at 03:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Frederic Weisbecker
On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu:

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 09:23:12PM +0800, Wangnan (F) escreveu: > On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: > >From: Arnaldo Carvalho de Melo > >Which is the most common default found in other similar tools. > Could you please show me some example about "other similar tools"? > For me,

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Wangnan (F)
Hi Arnaldo, On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: From: Arnaldo Carvalho de Melo Which is the most common default found in other similar tools. Could you please show me some example about "other similar tools"? For me, in most of the case I prefer callee order because most of

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > > So are you advocating different defaults, one for --stdio (callee), > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Frederic Weisbecker
On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > So are you advocating different defaults, one for --stdio (callee), > another for --tui, --gtk (caller)? > > This is all configurable via ~/.perfconfig

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > On Fri, Oct 9, 2015 at 3:25 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > Em Fri, Oct

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > On Fri, Oct 9, 2015 at 3:25 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > >>

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Frederic Weisbecker
On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > So are you advocating different defaults, one for --stdio (callee), > another for --tui, --gtk (caller)? > > This is all configurable via ~/.perfconfig

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Frederic Weisbecker
On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu:

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > > > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Namhyung Kim
Hi Arnaldo, On Tue, Oct 20, 2015 at 03:44:04PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 07:21:16PM +0200, Frederic Weisbecker escreveu: > > On Tue, Oct 20, 2015 at 10:06:51AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Namhyung Kim
On Tue, Oct 20, 2015 at 11:38:16AM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 20, 2015 at 09:23:12PM +0800, Wangnan (F) escreveu: > > On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: > > >From: Arnaldo Carvalho de Melo > > >Which is the most common default found in

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Wangnan (F)
Hi Arnaldo, On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: From: Arnaldo Carvalho de Melo Which is the most common default found in other similar tools. Could you please show me some example about "other similar tools"? For me, in most of the case I prefer callee order

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu: > On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu: > > So are you advocating different defaults, one for --stdio (callee), > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2015 at 09:23:12PM +0800, Wangnan (F) escreveu: > On 2015/10/6 5:03, Arnaldo Carvalho de Melo wrote: > >From: Arnaldo Carvalho de Melo > >Which is the most common default found in other similar tools. > Could you please show me some example about "other similar

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-19 Thread Brendan Gregg
On Fri, Oct 9, 2015 at 3:25 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: >> > > On Mon, Oct

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-19 Thread Brendan Gregg
On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim wrote: > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: >> From: Arnaldo Carvalho de Melo >> >> Which is the most common default found in other similar tools. > > I think it's more useful to change the default only when

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-19 Thread Brendan Gregg
On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim wrote: > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: >> From: Arnaldo Carvalho de Melo >> >> Which is the most common default found in other similar tools. > > I think it's more

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-19 Thread Brendan Gregg
On Fri, Oct 9, 2015 at 3:25 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Fri, Oct 09, 2015 at 01:34:33PM

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-12 Thread Namhyung Kim
On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. I think it's more useful to change the default only when --children is used. And there's a related issue too - please

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-12 Thread Frederic Weisbecker
On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. > > Requested-by: Ingo Molnar > Cc: Adrian Hunter > Cc: Borislav Petkov > Cc: Chandler Carruth > Cc: David Ahern >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-12 Thread Frederic Weisbecker
On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. > > Requested-by: Ingo Molnar > Cc: Adrian Hunter > Cc:

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-12 Thread Namhyung Kim
On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. I think it's more useful to change the default only when --children is used. And there's a related

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Ingo Molnar
* Brendan Gregg wrote: > On Sat, Oct 10, 2015 at 12:09 AM, Ingo Molnar wrote: > > > > * Brendan Gregg wrote: > > > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > > >> > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > >> > > On Mon, Oct 5,

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Brendan Gregg
On Sat, Oct 10, 2015 at 12:09 AM, Ingo Molnar wrote: > > * Brendan Gregg wrote: > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: >> > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo >>

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Ingo Molnar
* Brendan Gregg wrote: > On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > > > wrote: > > > > > > > > From: Arnaldo Carvalho de Melo > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Ingo Molnar
* Brendan Gregg wrote: > On Sat, Oct 10, 2015 at 12:09 AM, Ingo Molnar wrote: > > > > * Brendan Gregg wrote: > > > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Brendan Gregg
On Sat, Oct 10, 2015 at 12:09 AM, Ingo Molnar wrote: > > * Brendan Gregg wrote: > >> On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-10 Thread Ingo Molnar
* Brendan Gregg wrote: > On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: > On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > > > wrote: > > > > > >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Brendan Gregg
On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > > wrote: > > > > > > From: Arnaldo Carvalho de Melo > > > > > > Which is the most common default

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > wrote: > > > > From: Arnaldo Carvalho de Melo > > > > Which is the most common default found in other similar tools. > > Interactive tools, sure, like the perf report

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Brendan Gregg
On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. Interactive tools, sure, like the perf report TUI. But this also changes the ordering of the non-interactive tools which dump

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Brendan Gregg
On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > > wrote: > > > > > > From: Arnaldo Carvalho de Melo

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 03:10:29PM -0700, Brendan Gregg escreveu: > On Fri, Oct 9, 2015 at 2:56 PM, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > > > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo >

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Brendan Gregg
On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo > > Which is the most common default found in other similar tools. Interactive tools, sure, like the perf report TUI. But this also changes the ordering of the

Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-09 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2015 at 01:34:33PM -0700, Brendan Gregg escreveu: > On Mon, Oct 5, 2015 at 2:03 PM, Arnaldo Carvalho de Melo > wrote: > > > > From: Arnaldo Carvalho de Melo > > > > Which is the most common default found in other similar tools. > > Interactive

[PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-05 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Which is the most common default found in other similar tools. Requested-by: Ingo Molnar Cc: Adrian Hunter Cc: Borislav Petkov Cc: Chandler Carruth Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Cc: Wang Nan

[PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

2015-10-05 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Which is the most common default found in other similar tools. Requested-by: Ingo Molnar Cc: Adrian Hunter Cc: Borislav Petkov Cc: Chandler Carruth Cc: David Ahern