Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-29 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > > The main motivation was to have the arch in control of as much direct > register writing as possible. Even though our HV does allow us to write > to config space, it's not obviously safe for Linux to be flipping bits > and also calling the HV to

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-29 Thread Michael Ellerman
On Wed, 2007-03-28 at 00:39 -0600, Eric W. Biederman wrote: > Michael Ellerman <[EMAIL PROTECTED]> writes: > > > It's an arch detail whether MSI irqs need to be masked using the PCI > > MSI registers. > > Agreed. It isn't an arch detail that they need to be unmasked in > the pci configuration

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-29 Thread Michael Ellerman
On Wed, 2007-03-28 at 00:39 -0600, Eric W. Biederman wrote: Michael Ellerman [EMAIL PROTECTED] writes: It's an arch detail whether MSI irqs need to be masked using the PCI MSI registers. Agreed. It isn't an arch detail that they need to be unmasked in the pci configuration space. I

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-29 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: The main motivation was to have the arch in control of as much direct register writing as possible. Even though our HV does allow us to write to config space, it's not obviously safe for Linux to be flipping bits and also calling the HV to configure

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-27 Thread Eric W. Biederman
Michael Ellerman <[EMAIL PROTECTED]> writes: > It's an arch detail whether MSI irqs need to be masked using the PCI > MSI registers. Agreed. It isn't an arch detail that they need to be unmasked in the pci configuration space. I assume this patch is motivated just to make arch support easier

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: It's an arch detail whether MSI irqs need to be masked using the PCI MSI registers. Agreed. It isn't an arch detail that they need to be unmasked in the pci configuration space. I assume this patch is motivated just to make arch support easier and