Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > During the initial setup of a logical channel, it is necessary to unmask > the GIM in order to receive generated terminal count and error interrupts. > We're separating out this required code so it will be possible to move > the remaining code

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: During the initial setup of a logical channel, it is necessary to unmask the GIM in order to receive generated terminal count and error interrupts. We're separating out this required code so it will be possible to move

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-24 Thread Lee Jones
On Mon, 22 Apr 2013, Lee Jones wrote: > > > void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > >u32 *src_cfg, u32 *dst_cfg, bool is_log) > > > @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > > src |= 1 << D40_SREG_CFG_PRI_POS; > > >

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-24 Thread Lee Jones
On Mon, 22 Apr 2013, Lee Jones wrote: void d40_phy_cfg(struct stedma40_chan_cfg *cfg, u32 *src_cfg, u32 *dst_cfg, bool is_log) @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, src |= 1 D40_SREG_CFG_PRI_POS; dst |=

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-22 Thread Lee Jones
> > void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > u32 *src_cfg, u32 *dst_cfg, bool is_log) > > @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > src |= 1 << D40_SREG_CFG_PRI_POS; > > dst |= 1 <<

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:57AM +0100, Lee Jones wrote: > During the initial setup of a logical channel, it is necessary to unmask > the GIM in order to receive generated terminal count and error interrupts. > We're separating out this required code so it will be possible to move > the

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:57AM +0100, Lee Jones wrote: During the initial setup of a logical channel, it is necessary to unmask the GIM in order to receive generated terminal count and error interrupts. We're separating out this required code so it will be possible to move the remaining

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-22 Thread Lee Jones
void d40_phy_cfg(struct stedma40_chan_cfg *cfg, u32 *src_cfg, u32 *dst_cfg, bool is_log) @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, src |= 1 D40_SREG_CFG_PRI_POS; dst |= 1 D40_SREG_CFG_PRI_POS; shouldnt

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Lee Jones wrote: > During the initial setup of a logical channel, it is necessary to unmask > the GIM in order to receive generated terminal count and error interrupts. > We're separating out this required code so it will be possible to move > the remaining code in

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 11:11:57AM +0100, Lee Jones wrote: > +void d40_log_gim_unmask(u32 *src_cfg, u32 *dst_cfg) { > + > + *src_cfg |= 1 << D40_SREG_CFG_LOG_GIM_POS; > + *dst_cfg |= 1 << D40_SREG_CFG_LOG_GIM_POS; So, in patch 3, you started using the BIT() macro. But here it's fine not

[PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Lee Jones
During the initial setup of a logical channel, it is necessary to unmask the GIM in order to receive generated terminal count and error interrupts. We're separating out this required code so it will be possible to move the remaining code in d40_phy_cfg(), which is mostly runtime configuration into

[PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Lee Jones
During the initial setup of a logical channel, it is necessary to unmask the GIM in order to receive generated terminal count and error interrupts. We're separating out this required code so it will be possible to move the remaining code in d40_phy_cfg(), which is mostly runtime configuration into

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 11:11:57AM +0100, Lee Jones wrote: +void d40_log_gim_unmask(u32 *src_cfg, u32 *dst_cfg) { + + *src_cfg |= 1 D40_SREG_CFG_LOG_GIM_POS; + *dst_cfg |= 1 D40_SREG_CFG_LOG_GIM_POS; So, in patch 3, you started using the BIT() macro. But here it's fine not to

Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Lee Jones wrote: During the initial setup of a logical channel, it is necessary to unmask the GIM in order to receive generated terminal count and error interrupts. We're separating out this required code so it will be possible to move the remaining code in