Re: [PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-30 Thread Joonsoo Kim
On Mon, Jul 29, 2013 at 04:19:10PM -0400, Naoya Horiguchi wrote: > On Mon, Jul 29, 2013 at 02:32:07PM +0900, Joonsoo Kim wrote: > > If we fail with a reserved page, just calling put_page() is not sufficient, > > because put_page() invoke free_huge_page() at last step and it doesn't > > know

Re: [PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-30 Thread Joonsoo Kim
On Mon, Jul 29, 2013 at 04:19:10PM -0400, Naoya Horiguchi wrote: On Mon, Jul 29, 2013 at 02:32:07PM +0900, Joonsoo Kim wrote: If we fail with a reserved page, just calling put_page() is not sufficient, because put_page() invoke free_huge_page() at last step and it doesn't know whether a

Re: [PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-29 Thread Naoya Horiguchi
On Mon, Jul 29, 2013 at 02:32:07PM +0900, Joonsoo Kim wrote: > If we fail with a reserved page, just calling put_page() is not sufficient, > because put_page() invoke free_huge_page() at last step and it doesn't > know whether a page comes from a reserved pool or not. So it doesn't do > anything

Re: [PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-29 Thread Naoya Horiguchi
On Mon, Jul 29, 2013 at 02:32:07PM +0900, Joonsoo Kim wrote: If we fail with a reserved page, just calling put_page() is not sufficient, because put_page() invoke free_huge_page() at last step and it doesn't know whether a page comes from a reserved pool or not. So it doesn't do anything

[PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-28 Thread Joonsoo Kim
If we fail with a reserved page, just calling put_page() is not sufficient, because put_page() invoke free_huge_page() at last step and it doesn't know whether a page comes from a reserved pool or not. So it doesn't do anything related to reserved count. This makes reserve count lower than how we

[PATCH 16/18] mm, hugetlb: return a reserved page to a reserved pool if failed

2013-07-28 Thread Joonsoo Kim
If we fail with a reserved page, just calling put_page() is not sufficient, because put_page() invoke free_huge_page() at last step and it doesn't know whether a page comes from a reserved pool or not. So it doesn't do anything related to reserved count. This makes reserve count lower than how we