Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-28 Thread Joel Stanley
On Mon, 12 Oct 2020 at 05:25, Billy Tsai wrote: > > Hi Joel, > > On 2020/10/8, 11:49 AM, Joel Stanley wrote: > > On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl > setting > > > for sgpiom1 > > >

Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-11 Thread Billy Tsai
Hi Joel, On 2020/10/8, 11:49 AM, Joel Stanley wrote: On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > > for sgpiom1 > > The code looks good Billy. > > Please split the change in

Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-11 Thread Billy Tsai
Hi Joel, Thanks for your advice. On 2020/10/8, 11:49 AM, Joel Stanley wrote: > On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > > for sgpiom1 > > The code looks good Billy. > >

Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-07 Thread Joel Stanley
On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > for sgpiom1 The code looks good Billy. Please split the change in two: device tree changes (arch/arm/dts) in one, and pinctrl in the second, as they go through

[PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-07 Thread Billy Tsai
This patch is used to add sgpiom and sgpios nodes and add pinctrl setting for sgpiom1 Signed-off-by: Billy Tsai --- arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi | 5 ++ arch/arm/boot/dts/aspeed-g6.dtsi | 53 ++ drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 30