Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-07 Thread Maciej W. Rozycki
On Wed, 7 Nov 2018, Christoph Hellwig wrote: > Do we really need a new source file just to call swiotlb_init? I think it being a separate file is actually good, as it saves a little bit of code space at run time if this is not used without the need to wrap the entire function into #ifdef. >

Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-07 Thread Maciej W. Rozycki
On Wed, 7 Nov 2018, Christoph Hellwig wrote: > Do we really need a new source file just to call swiotlb_init? I think it being a separate file is actually good, as it saves a little bit of code space at run time if this is not used without the need to wrap the entire function into #ifdef. >

Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-06 Thread Christoph Hellwig
Do we really need a new source file just to call swiotlb_init? And if we do that file should have a SPDX header these days. Otherwise looks fine: Reviewed-by: Christoph Hellwig

Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-06 Thread Christoph Hellwig
Do we really need a new source file just to call swiotlb_init? And if we do that file should have a SPDX header these days. Otherwise looks fine: Reviewed-by: Christoph Hellwig

[PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-06 Thread Maciej W. Rozycki
The Broadcom SiByte BCM1250, BCM1125, and BCM1125H SOCs have an onchip DRAM controller that supports memory amounts of up to 16GiB, and due to how the address decoder has been wired in the SOC any memory beyond 1GiB is actually mapped starting from 4GiB physical up, that is beyond the 32-bit

[PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur

2018-11-06 Thread Maciej W. Rozycki
The Broadcom SiByte BCM1250, BCM1125, and BCM1125H SOCs have an onchip DRAM controller that supports memory amounts of up to 16GiB, and due to how the address decoder has been wired in the SOC any memory beyond 1GiB is actually mapped starting from 4GiB physical up, that is beyond the 32-bit