Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-03-07 Thread Gu Zheng
ping... On 02/28/2014 06:27 PM, Gu Zheng wrote: > Commit 5ffac122dbda8(aio: Don't use ctx->tail unnecessarily) uses > ring->tail rather than the ctx->tail, but with this change, we fetch 'tail' > only once at the start, so that we can not be aware of adding event by > aio_complete > when

Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-03-07 Thread Gu Zheng
ping... On 02/28/2014 06:27 PM, Gu Zheng wrote: Commit 5ffac122dbda8(aio: Don't use ctx-tail unnecessarily) uses ring-tail rather than the ctx-tail, but with this change, we fetch 'tail' only once at the start, so that we can not be aware of adding event by aio_complete when reading

Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-03-02 Thread Gu Zheng
Hi Kent, Sorry for late replay. On 03/01/2014 04:52 AM, Kent Overstreet wrote: > On Fri, Feb 28, 2014 at 06:27:18PM +0800, Gu Zheng wrote: >> Commit 5ffac122dbda8(aio: Don't use ctx->tail unnecessarily) uses >> ring->tail rather than the ctx->tail, but with this change, we fetch 'tail' >> only

Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-03-02 Thread Gu Zheng
Hi Kent, Sorry for late replay. On 03/01/2014 04:52 AM, Kent Overstreet wrote: On Fri, Feb 28, 2014 at 06:27:18PM +0800, Gu Zheng wrote: Commit 5ffac122dbda8(aio: Don't use ctx-tail unnecessarily) uses ring-tail rather than the ctx-tail, but with this change, we fetch 'tail' only once at the

Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-02-28 Thread Kent Overstreet
On Fri, Feb 28, 2014 at 06:27:18PM +0800, Gu Zheng wrote: > Commit 5ffac122dbda8(aio: Don't use ctx->tail unnecessarily) uses > ring->tail rather than the ctx->tail, but with this change, we fetch 'tail' > only once at the start, so that we can not be aware of adding event by > aio_complete >

[PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-02-28 Thread Gu Zheng
Commit 5ffac122dbda8(aio: Don't use ctx->tail unnecessarily) uses ring->tail rather than the ctx->tail, but with this change, we fetch 'tail' only once at the start, so that we can not be aware of adding event by aio_complete when reading events. It seems a regression. So here we fetch the

[PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-02-28 Thread Gu Zheng
Commit 5ffac122dbda8(aio: Don't use ctx-tail unnecessarily) uses ring-tail rather than the ctx-tail, but with this change, we fetch 'tail' only once at the start, so that we can not be aware of adding event by aio_complete when reading events. It seems a regression. So here we fetch the ring-tail

Re: [PATCH 2/2] aio: make aio_read_events_ring be aware of aio_complete

2014-02-28 Thread Kent Overstreet
On Fri, Feb 28, 2014 at 06:27:18PM +0800, Gu Zheng wrote: Commit 5ffac122dbda8(aio: Don't use ctx-tail unnecessarily) uses ring-tail rather than the ctx-tail, but with this change, we fetch 'tail' only once at the start, so that we can not be aware of adding event by aio_complete when