Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-13 Thread atull
On Tue, 12 Jul 2016, Moritz Fischer wrote: > Hi Alan, > > couple of nits inline below. > Hi Moritz! Thanks for your review! > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > wrote: > > > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-13 Thread atull
On Tue, 12 Jul 2016, Moritz Fischer wrote: > Hi Alan, > > couple of nits inline below. > Hi Moritz! Thanks for your review! > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > wrote: > > > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32 > > flags) > > +{ > > +

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-13 Thread atull
On Tue, 12 Jul 2016, Russell King - ARM Linux wrote: > On Tue, Jul 12, 2016 at 02:31:05PM -0700, Moritz Fischer wrote: > > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > > wrote: > > > + priv->clk = devm_clk_get(dev, NULL); > > > + if (IS_ERR(priv->clk))

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-13 Thread atull
On Tue, 12 Jul 2016, Russell King - ARM Linux wrote: > On Tue, Jul 12, 2016 at 02:31:05PM -0700, Moritz Fischer wrote: > > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > > wrote: > > > + priv->clk = devm_clk_get(dev, NULL); > > > + if (IS_ERR(priv->clk)) { > > > +

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Russell King - ARM Linux
On Tue, Jul 12, 2016 at 02:31:05PM -0700, Moritz Fischer wrote: > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > wrote: > > + priv->clk = devm_clk_get(dev, NULL); > > + if (IS_ERR(priv->clk)) { > > + dev_err(dev, "no clock specified\n"); > >

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Russell King - ARM Linux
On Tue, Jul 12, 2016 at 02:31:05PM -0700, Moritz Fischer wrote: > On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull > wrote: > > + priv->clk = devm_clk_get(dev, NULL); > > + if (IS_ERR(priv->clk)) { > > + dev_err(dev, "no clock specified\n"); > > + return

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Moritz Fischer
Hi Alan, couple of nits inline below. On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32 > flags) > +{ > + struct a10_fpga_priv *priv = mgr->priv; > + u32 reg; > + int

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Moritz Fischer
Hi Alan, couple of nits inline below. On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32 > flags) > +{ > + struct a10_fpga_priv *priv = mgr->priv; > + u32 reg; > + int ret; > + > + /* Wait for

[PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Alan Tull
Add low level driver to support reprogramming FPGAs for Altera SoCFPGA Arria10. Signed-off-by: Alan Tull --- drivers/fpga/Kconfig | 6 + drivers/fpga/Makefile | 1 + drivers/fpga/socfpga-a10.c | 573 + 3

[PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

2016-07-12 Thread Alan Tull
Add low level driver to support reprogramming FPGAs for Altera SoCFPGA Arria10. Signed-off-by: Alan Tull --- drivers/fpga/Kconfig | 6 + drivers/fpga/Makefile | 1 + drivers/fpga/socfpga-a10.c | 573 + 3 files changed, 580 insertions(+)