Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Jacek, On 8 May 2018 at 04:13, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the patch. Generally this is a nice and clean driver, > but I noticed some locking related issues and one detail > regarding LED naming. Please refer below. > > > On 05/04/2018

Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Jacek, On 8 May 2018 at 04:13, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the patch. Generally this is a nice and clean driver, > but I noticed some locking related issues and one detail > regarding LED naming. Please refer below. > > > On 05/04/2018 12:08 PM, Baolin Wang wrote:

Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Baolin, Thank you for the patch. Generally this is a nice and clean driver, but I noticed some locking related issues and one detail regarding LED naming. Please refer below. On 05/04/2018 12:08 PM, Baolin Wang wrote: From: Xiaotong Lu This patch adds

Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Baolin, Thank you for the patch. Generally this is a nice and clean driver, but I noticed some locking related issues and one detail regarding LED naming. Please refer below. On 05/04/2018 12:08 PM, Baolin Wang wrote: From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series

RE: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Hi Xiaotong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc3 next

RE: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver Hi Xiaotong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc3 next

Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Xiaotong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc3 next-20180504] [cannot apply to j.anaszewski-leds/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

Hi Xiaotong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc3 next-20180504] [cannot apply to j.anaszewski-leds/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve

[PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. Signed-off-by: Xiaotong Lu Signed-off-by: Baolin Wang

[PATCH 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. Signed-off-by: Xiaotong Lu Signed-off-by: Baolin Wang --- drivers/leds/Kconfig| 11 ++