Re: [PATCH 2/2] m68k: m68328: remove duplicate code

2020-11-01 Thread Greg Ungerer
Hi Arnd, On 31/10/20 12:25 am, Arnd Bergmann wrote: On Mon, Oct 19, 2020 at 2:06 PM Arnd Bergmann wrote: On Mon, Oct 19, 2020 at 1:45 AM Greg Ungerer wrote: On 15/10/20 10:32 pm, Arnd Bergmann wrote: diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine index

Re: [PATCH 2/2] m68k: m68328: remove duplicate code

2020-10-18 Thread Greg Ungerer
Hi Arnd, Overall looks good. On 15/10/20 10:32 pm, Arnd Bergmann wrote: [snip] diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu index 694c4fca9f5d..a65ce7618232 100644 --- a/arch/m68k/Kconfig.cpu +++ b/arch/m68k/Kconfig.cpu @@ -35,7 +35,7 @@ endchoice if M68KCLASSIC config

[PATCH 2/2] m68k: m68328: remove duplicate code

2020-10-15 Thread Arnd Bergmann
Building a kernel with multiple dragonball based boards enabled needlessly causes a link failure because of duplicate config_BSP() functions between the CPU versions. Avoid that merging the three almost identical files into one, and hiding the CPU configuration behind the board config. The