Re: [PATCH 2/2] mm,swap: skip swap readahead if page was obtained instantaneously

2020-09-23 Thread Christoph Hellwig
On Mon, Sep 21, 2020 at 10:01:48PM -0400, Rik van Riel wrote: > + struct page *page; > unsigned long entry_offset = swp_offset(entry); > unsigned long offset = entry_offset; > unsigned long start_offset, end_offset; > @@ -668,11 +669,18 @@ struct page

Re: [PATCH 2/2] mm,swap: skip swap readahead if page was obtained instantaneously

2020-09-22 Thread Rik van Riel
On Tue, 2020-09-22 at 11:13 +0800, huang ying wrote: > On Tue, Sep 22, 2020 at 10:02 AM Rik van Riel > wrote: > > Check whether a swap page was obtained instantaneously, for example > > because it is in zswap, or on a very fast IO device which uses busy > > waiting, and we did not wait on IO to

Re: [PATCH 2/2] mm,swap: skip swap readahead if page was obtained instantaneously

2020-09-21 Thread huang ying
On Tue, Sep 22, 2020 at 10:02 AM Rik van Riel wrote: > > Check whether a swap page was obtained instantaneously, for example > because it is in zswap, or on a very fast IO device which uses busy > waiting, and we did not wait on IO to swap in this page. > If no IO was needed to get the swap page

[PATCH 2/2] mm,swap: skip swap readahead if page was obtained instantaneously

2020-09-21 Thread Rik van Riel
Check whether a swap page was obtained instantaneously, for example because it is in zswap, or on a very fast IO device which uses busy waiting, and we did not wait on IO to swap in this page. If no IO was needed to get the swap page we want, kicking off readahead on surrounding swap pages is