Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-09 Thread Jérémie Galarneau
Hi He, This commit should fix the problem: commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334 Author: Jérémie Galarneau Date: Thu Apr 9 14:57:44 2015 -0400 Fix: Allow the addition of environment fields to a frozen trace Commit 7f800dc7 introduced a behavior change which made it

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-09 Thread He Kuang
On 2015/4/9 1:59, Jiri Olsa wrote: On Wed, Apr 08, 2015 at 12:49:20PM +0800, He Kuang wrote: Due to babeltrace commit: 7f800dc7c2a1 ("ir: make trace environment use bt_object") The trace->frozen flag is set in bt_ctf_trace_create_stream(), this flag is checked before adding environment

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-09 Thread He Kuang
On 2015/4/9 1:59, Jiri Olsa wrote: On Wed, Apr 08, 2015 at 12:49:20PM +0800, He Kuang wrote: Due to babeltrace commit: 7f800dc7c2a1 (ir: make trace environment use bt_object) The trace-frozen flag is set in bt_ctf_trace_create_stream(), this flag is checked before adding environment field

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-09 Thread Jérémie Galarneau
Hi He, This commit should fix the problem: commit a0d129162d2fdd1a99553a6cfbdf4e77ad3f7334 Author: Jérémie Galarneau jeremie.galarn...@efficios.com Date: Thu Apr 9 14:57:44 2015 -0400 Fix: Allow the addition of environment fields to a frozen trace Commit 7f800dc7 introduced a

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-08 Thread Jiri Olsa
On Wed, Apr 08, 2015 at 12:49:20PM +0800, He Kuang wrote: > Due to babeltrace commit: > 7f800dc7c2a1 ("ir: make trace environment use bt_object") > > The trace->frozen flag is set in bt_ctf_trace_create_stream(), this flag > is checked before adding environment field to trace, and causes >

Re: [PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-08 Thread Jiri Olsa
On Wed, Apr 08, 2015 at 12:49:20PM +0800, He Kuang wrote: Due to babeltrace commit: 7f800dc7c2a1 (ir: make trace environment use bt_object) The trace-frozen flag is set in bt_ctf_trace_create_stream(), this flag is checked before adding environment field to trace, and causes

[PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-07 Thread He Kuang
Due to babeltrace commit: 7f800dc7c2a1 ("ir: make trace environment use bt_object") The trace->frozen flag is set in bt_ctf_trace_create_stream(), this flag is checked before adding environment field to trace, and causes ctf_writer__setup_env() failed. Fix this by setting all environment fields

[PATCH 2/2] perf data: Fix ctf_writer setupenv failure

2015-04-07 Thread He Kuang
Due to babeltrace commit: 7f800dc7c2a1 (ir: make trace environment use bt_object) The trace-frozen flag is set in bt_ctf_trace_create_stream(), this flag is checked before adding environment field to trace, and causes ctf_writer__setup_env() failed. Fix this by setting all environment fields