Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Thu 2017-07-27 18:51:01, Sergey Senozhatsky wrote: > On (07/27/17 11:29), Petr Mladek wrote: > [..] > > > > Signed-off-by: Petr Mladek > > > > > > Reviewed-by: Sergey Senozhatsky > > > > Thanks for the review. I am going to push the two

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Thu 2017-07-27 18:51:01, Sergey Senozhatsky wrote: > On (07/27/17 11:29), Petr Mladek wrote: > [..] > > > > Signed-off-by: Petr Mladek > > > > > > Reviewed-by: Sergey Senozhatsky > > > > Thanks for the review. I am going to push the two patches into > > for-4.14 branch so that we could get

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/27/17 11:28), Petr Mladek wrote: > > well, the console output is far from perfect, so I can imagine future > > changes ;) > > Sure and we will need to deal with it. Anyway, I still thing that this > check is better than nothing. Even if we "fix" all consoles and move > them out of init

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/27/17 11:28), Petr Mladek wrote: > > well, the console output is far from perfect, so I can imagine future > > changes ;) > > Sure and we will need to deal with it. Anyway, I still thing that this > check is better than nothing. Even if we "fix" all consoles and move > them out of init

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/27/17 11:29), Petr Mladek wrote: [..] > > > Signed-off-by: Petr Mladek > > > > Reviewed-by: Sergey Senozhatsky > > Thanks for the review. I am going to push the two patches into > for-4.14 branch so that we could get some testing via

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/27/17 11:29), Petr Mladek wrote: [..] > > > Signed-off-by: Petr Mladek > > > > Reviewed-by: Sergey Senozhatsky > > Thanks for the review. I am going to push the two patches into > for-4.14 branch so that we could get some testing via linux-next. good. agree. how do you think, would

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Wed 2017-07-26 22:08:04, Sergey Senozhatsky wrote: > On (07/14/17 14:51), Petr Mladek wrote: > > printk_late_init() is responsible for disabling boot consoles that > > use init memory. It checks the address of struct console for this. > > > > But this is not enough. For example, there are

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Wed 2017-07-26 22:08:04, Sergey Senozhatsky wrote: > On (07/14/17 14:51), Petr Mladek wrote: > > printk_late_init() is responsible for disabling boot consoles that > > use init memory. It checks the address of struct console for this. > > > > But this is not enough. For example, there are

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Mon 2017-07-24 11:03:56, Sergey Senozhatsky wrote: > Hello, > > On (07/21/17 16:32), Petr Mladek wrote: > [..] > > > sort of a problem here is that the next time anyone adds a new ->foo() > > > callback to struct console, that person also needs to remember to update > > > printk_late_init(). >

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Mon 2017-07-24 11:03:56, Sergey Senozhatsky wrote: > Hello, > > On (07/21/17 16:32), Petr Mladek wrote: > [..] > > > sort of a problem here is that the next time anyone adds a new ->foo() > > > callback to struct console, that person also needs to remember to update > > > printk_late_init(). >

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/14/17 14:51), Petr Mladek wrote: > printk_late_init() is responsible for disabling boot consoles that > use init memory. It checks the address of struct console for this. > > But this is not enough. For example, there are several early > consoles that have write() method in the init

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/14/17 14:51), Petr Mladek wrote: > printk_late_init() is responsible for disabling boot consoles that > use init memory. It checks the address of struct console for this. > > But this is not enough. For example, there are several early > consoles that have write() method in the init

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

Hello, On (07/21/17 16:32), Petr Mladek wrote: [..] > > sort of a problem here is that the next time anyone adds a new ->foo() > > callback to struct console, that person also needs to remember to update > > printk_late_init(). > > I am not super happy with this as well. Any hint how to do it

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

Hello, On (07/21/17 16:32), Petr Mladek wrote: [..] > > sort of a problem here is that the next time anyone adds a new ->foo() > > callback to struct console, that person also needs to remember to update > > printk_late_init(). > > I am not super happy with this as well. Any hint how to do it

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Sat 2017-07-15 07:06:26, Sergey Senozhatsky wrote: > On (07/14/17 14:51), Petr Mladek wrote: > [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index f35d3ac3b8c7..1ebe1525ef64 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -2659,8

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On Sat 2017-07-15 07:06:26, Sergey Senozhatsky wrote: > On (07/14/17 14:51), Petr Mladek wrote: > [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index f35d3ac3b8c7..1ebe1525ef64 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -2659,8

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/14/17 14:51), Petr Mladek wrote: [..] > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index f35d3ac3b8c7..1ebe1525ef64 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2659,8 +2659,16 @@ static int __init printk_late_init(void) > int ret; >

Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory

On (07/14/17 14:51), Petr Mladek wrote: [..] > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index f35d3ac3b8c7..1ebe1525ef64 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2659,8 +2659,16 @@ static int __init printk_late_init(void) > int ret; >

[PATCH 2/2] printk/console: Enhance the check for consoles using init memory

printk_late_init() is responsible for disabling boot consoles that use init memory. It checks the address of struct console for this. But this is not enough. For example, there are several early consoles that have write() method in the init section and struct console in the normal section. They

[PATCH 2/2] printk/console: Enhance the check for consoles using init memory

printk_late_init() is responsible for disabling boot consoles that use init memory. It checks the address of struct console for this. But this is not enough. For example, there are several early consoles that have write() method in the init section and struct console in the normal section. They