Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread Omar Sandoval
On Thu, Apr 09, 2015 at 06:28:48PM +0200, David Sterba wrote: > On Tue, Apr 07, 2015 at 10:34:01PM -0700, Omar Sandoval wrote: > > Currently, mounting a subvolume with subvolid= takes a different code > > path than mounting with subvol=. This isn't really a big deal except for > > the fact that

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread David Sterba
On Tue, Apr 07, 2015 at 10:34:01PM -0700, Omar Sandoval wrote: > Currently, mounting a subvolume with subvolid= takes a different code > path than mounting with subvol=. This isn't really a big deal except for > the fact that mounts done with subvolid= or the default subvolume don't > have a

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread David Sterba
On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: > > > Original Message > Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting > From: Omar Sandoval > To: Chris Mason , Josef Bacik , David Sterba > , > Date: 2015年04月08日 13:34 &g

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread David Sterba
On Tue, Apr 07, 2015 at 10:34:01PM -0700, Omar Sandoval wrote: Currently, mounting a subvolume with subvolid= takes a different code path than mounting with subvol=. This isn't really a big deal except for the fact that mounts done with subvolid= or the default subvolume don't have a dentry

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread David Sterba
On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: Original Message Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval osan...@osandov.com To: Chris Mason c...@fb.com, Josef Bacik jba...@fb.com, David Sterba dste...@suse.cz

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-09 Thread Omar Sandoval
On Thu, Apr 09, 2015 at 06:28:48PM +0200, David Sterba wrote: On Tue, Apr 07, 2015 at 10:34:01PM -0700, Omar Sandoval wrote: Currently, mounting a subvolume with subvolid= takes a different code path than mounting with subvol=. This isn't really a big deal except for the fact that mounts

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval To: Qu Wenruo Date: 2015年04月08日 15:17 On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: Original Message Subject: [PATCH 2/3] Btrfs

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Omar Sandoval
On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: > > > Original Message > Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting > From: Omar Sandoval > To: Chris Mason , Josef Bacik , David Sterba > , > Date: 2015年04月08日 13:34 &

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Qu Wenruo
Original Message Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval To: Chris Mason , Josef Bacik , David Sterba , Date: 2015年04月08日 13:34 Currently, mounting a subvolume with subvolid= takes a different code path than mounting

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Qu Wenruo
Original Message Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval osan...@osandov.com To: Chris Mason c...@fb.com, Josef Bacik jba...@fb.com, David Sterba dste...@suse.cz, linux-bt...@vger.kernel.org Date: 2015年04月08日 13:34 Currently

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Omar Sandoval
On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: Original Message Subject: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval osan...@osandov.com To: Chris Mason c...@fb.com, Josef Bacik jba...@fb.com, David Sterba dste...@suse.cz

Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-08 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting From: Omar Sandoval osan...@osandov.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2015年04月08日 15:17 On Wed, Apr 08, 2015 at 02:06:14PM +0800, Qu Wenruo wrote: Original

[PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-07 Thread Omar Sandoval
Currently, mounting a subvolume with subvolid= takes a different code path than mounting with subvol=. This isn't really a big deal except for the fact that mounts done with subvolid= or the default subvolume don't have a dentry that's connected to the dentry tree like in the subvol= case. To

[PATCH 2/3] Btrfs: unify subvol= and subvolid= mounting

2015-04-07 Thread Omar Sandoval
Currently, mounting a subvolume with subvolid= takes a different code path than mounting with subvol=. This isn't really a big deal except for the fact that mounts done with subvolid= or the default subvolume don't have a dentry that's connected to the dentry tree like in the subvol= case. To