Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 11:58:52AM -0700, Casey Leedom wrote: > Okay, I'll leave the whole request_firmware{,_direct,_nowait}() thing > alone. The request_firmware_direct() will "solve" a non-problem (since all > of our "firmware" files are _supposed to be_ always present. The code does not

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Casey Leedom
Okay, I'll leave the whole request_firmware{,_direct,_nowait}() thing alone. The request_firmware_direct() will "solve" a non-problem (since all of our "firmware" files are _supposed to be_ always present. (And the 60 second timeout for udev to confirm that a file doesn't exist seems like

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 10:12:20AM -0700, Casey Leedom wrote: > > On 06/24/14 18:50, Luis R. Rodriguez wrote: >> On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: >>> [[ Hopefully this makes it through to the kernel.org lists -- I’m using the >>>Mac OS/X Mailer and it’s not clear

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Casey Leedom
On 06/24/14 18:50, Luis R. Rodriguez wrote: On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: [[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. -- Casey ]] So does

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Casey Leedom
On 06/24/14 18:50, Luis R. Rodriguez wrote: On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: [[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. -- Casey ]] So does

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 10:12:20AM -0700, Casey Leedom wrote: On 06/24/14 18:50, Luis R. Rodriguez wrote: On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: [[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Casey Leedom
Okay, I'll leave the whole request_firmware{,_direct,_nowait}() thing alone. The request_firmware_direct() will solve a non-problem (since all of our firmware files are _supposed to be_ always present. (And the 60 second timeout for udev to confirm that a file doesn't exist seems like udev

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-25 Thread Luis R. Rodriguez
On Wed, Jun 25, 2014 at 11:58:52AM -0700, Casey Leedom wrote: Okay, I'll leave the whole request_firmware{,_direct,_nowait}() thing alone. The request_firmware_direct() will solve a non-problem (since all of our firmware files are _supposed to be_ always present. The code does not reflect

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Luis R. Rodriguez
On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: > [[ Hopefully this makes it through to the kernel.org lists -- I’m using the > Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. > -- Casey ]] > > So does request_firmware_direct() only fail if the

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Casey Leedom
[[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. -- Casey ]] So does request_firmware_direct() only fail if the requested file is not present on the file system or does it fail in other

[PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" cxgb4 uses request_firmware() 3 times, one for firmware, one for optional configuration files and another for ethtools flash. Since the configuration update is optional on devices that don't have a configuration file update it means we'd wait unnecessarily for the extra

[PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com cxgb4 uses request_firmware() 3 times, one for firmware, one for optional configuration files and another for ethtools flash. Since the configuration update is optional on devices that don't have a configuration file update it means we'd wait unnecessarily

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Casey Leedom
[[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. -- Casey ]] So does request_firmware_direct() only fail if the requested file is not present on the file system or does it fail in other

Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct()

2014-06-24 Thread Luis R. Rodriguez
On Tue, Jun 24, 2014 at 03:54:44PM -0700, Casey Leedom wrote: [[ Hopefully this makes it through to the kernel.org lists -- I’m using the Mac OS/X Mailer and it’s not clear how to force it not to use HTML format. -- Casey ]] So does request_firmware_direct() only fail if the requested