Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-21 07:54, Vladimir Zapolskiy wrote: > Hi Peter, > > On 03/21/2018 07:53 AM, Peter Rosin wrote: >> On 2018-03-21 00:24, Vladimir Zapolskiy wrote: >>> Hi Peter, >>> >>> On 03/20/2018 11:31 AM, Peter Rosin wrote: In preparation for PCA9641 support, convert the mybus and busoff macros

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-21 07:54, Vladimir Zapolskiy wrote: > Hi Peter, > > On 03/21/2018 07:53 AM, Peter Rosin wrote: >> On 2018-03-21 00:24, Vladimir Zapolskiy wrote: >>> Hi Peter, >>> >>> On 03/20/2018 11:31 AM, Peter Rosin wrote: In preparation for PCA9641 support, convert the mybus and busoff macros

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

Hi Peter, On 03/21/2018 07:53 AM, Peter Rosin wrote: > On 2018-03-21 00:24, Vladimir Zapolskiy wrote: >> Hi Peter, >> >> On 03/20/2018 11:31 AM, Peter Rosin wrote: >>> In preparation for PCA9641 support, convert the mybus and busoff macros >>> to functions, and in the process prefix them with

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

Hi Peter, On 03/21/2018 07:53 AM, Peter Rosin wrote: > On 2018-03-21 00:24, Vladimir Zapolskiy wrote: >> Hi Peter, >> >> On 03/20/2018 11:31 AM, Peter Rosin wrote: >>> In preparation for PCA9641 support, convert the mybus and busoff macros >>> to functions, and in the process prefix them with

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-21 00:24, Vladimir Zapolskiy wrote: > Hi Peter, > > On 03/20/2018 11:31 AM, Peter Rosin wrote: >> In preparation for PCA9641 support, convert the mybus and busoff macros >> to functions, and in the process prefix them with pca9541_. Also prefix >> remaining chip specific macros with

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-21 00:24, Vladimir Zapolskiy wrote: > Hi Peter, > > On 03/20/2018 11:31 AM, Peter Rosin wrote: >> In preparation for PCA9641 support, convert the mybus and busoff macros >> to functions, and in the process prefix them with pca9541_. Also prefix >> remaining chip specific macros with

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

Hi Peter, On 03/20/2018 11:31 AM, Peter Rosin wrote: > In preparation for PCA9641 support, convert the mybus and busoff macros > to functions, and in the process prefix them with pca9541_. Also prefix > remaining chip specific macros with PCA9541_. > > Signed-off-by: Peter Rosin

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

Hi Peter, On 03/20/2018 11:31 AM, Peter Rosin wrote: > In preparation for PCA9641 support, convert the mybus and busoff macros > to functions, and in the process prefix them with pca9541_. Also prefix > remaining chip specific macros with PCA9541_. > > Signed-off-by: Peter Rosin > --- >

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On Tue, Mar 20, 2018 at 10:48:40PM +0100, Peter Rosin wrote: > On 2018-03-20 14:20, Guenter Roeck wrote: > > On 03/20/2018 02:31 AM, Peter Rosin wrote: > >> +static int pca9541_mybus(int ctl) > > > > bool ? > > > >> +{ > >> + if (!(ctl & PCA9541_MYBUS)) > >> + return 1; > > > > true ?

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On Tue, Mar 20, 2018 at 10:48:40PM +0100, Peter Rosin wrote: > On 2018-03-20 14:20, Guenter Roeck wrote: > > On 03/20/2018 02:31 AM, Peter Rosin wrote: > >> +static int pca9541_mybus(int ctl) > > > > bool ? > > > >> +{ > >> + if (!(ctl & PCA9541_MYBUS)) > >> + return 1; > > > > true ?

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-20 14:20, Guenter Roeck wrote: > On 03/20/2018 02:31 AM, Peter Rosin wrote: >> +static int pca9541_mybus(int ctl) > > bool ? > >> +{ >> +if (!(ctl & PCA9541_MYBUS)) >> +return 1; > > true ? > >> +return (ctl & PCA9541_MYBUS) == PCA9541_MYBUS; >> +} >> + >>

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 2018-03-20 14:20, Guenter Roeck wrote: > On 03/20/2018 02:31 AM, Peter Rosin wrote: >> +static int pca9541_mybus(int ctl) > > bool ? > >> +{ >> +if (!(ctl & PCA9541_MYBUS)) >> +return 1; > > true ? > >> +return (ctl & PCA9541_MYBUS) == PCA9541_MYBUS; >> +} >> + >>

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 03/20/2018 02:31 AM, Peter Rosin wrote: In preparation for PCA9641 support, convert the mybus and busoff macros to functions, and in the process prefix them with pca9541_. Also prefix remaining chip specific macros with PCA9541_. Signed-off-by: Peter Rosin ---

Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup

On 03/20/2018 02:31 AM, Peter Rosin wrote: In preparation for PCA9641 support, convert the mybus and busoff macros to functions, and in the process prefix them with pca9541_. Also prefix remaining chip specific macros with PCA9541_. Signed-off-by: Peter Rosin ---

[PATCH 2/3] i2c: mux: pca9541: namespace cleanup

In preparation for PCA9641 support, convert the mybus and busoff macros to functions, and in the process prefix them with pca9541_. Also prefix remaining chip specific macros with PCA9541_. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-pca9541.c | 26

[PATCH 2/3] i2c: mux: pca9541: namespace cleanup

In preparation for PCA9641 support, convert the mybus and busoff macros to functions, and in the process prefix them with pca9541_. Also prefix remaining chip specific macros with PCA9541_. Signed-off-by: Peter Rosin --- drivers/i2c/muxes/i2c-mux-pca9541.c | 26 +++--- 1