RE: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-22 Thread Sjur BRENDELAND
Hi Fernando, > > I think you drop the driver module's ref count during recovery, because > > rproc_shutdown calls module_put(). Maybe you should move driver > > ref count handling to rproc_add and rproc_type_release, instead of > > rproc_boot() and rproc_shutdown()? > > How could you remove the

RE: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-22 Thread Sjur BRENDELAND
Hi Fernando, I think you drop the driver module's ref count during recovery, because rproc_shutdown calls module_put(). Maybe you should move driver ref count handling to rproc_add and rproc_type_release, instead of rproc_boot() and rproc_shutdown()? How could you remove the remoteproc

Re: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-20 Thread Guzman Lugo, Fernando
Hi Sjur, On Mon, Aug 20, 2012 at 8:07 AM, Sjur Brændeland wrote: > > Hi Fernando, > > >This patch is introducing rproc_trigger_recover function which is in > >charge of recovering the rproc. One way to recover the rproc after a > > crash > >is resetting all its virtio devices. Doing that, all

Re: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-20 Thread Sjur Brændeland
Hi Fernando, >This patch is introducing rproc_trigger_recover function which is in >charge of recovering the rproc. One way to recover the rproc after a crash >is resetting all its virtio devices. Doing that, all rpmsg drivers are >restored along with the rpmsg devices and that also causes the

Re: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-20 Thread Sjur Brændeland
Hi Fernando, This patch is introducing rproc_trigger_recover function which is in charge of recovering the rproc. One way to recover the rproc after a crash is resetting all its virtio devices. Doing that, all rpmsg drivers are restored along with the rpmsg devices and that also causes the reset

Re: [PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-20 Thread Guzman Lugo, Fernando
Hi Sjur, On Mon, Aug 20, 2012 at 8:07 AM, Sjur Brændeland sjur.brandel...@stericsson.com wrote: Hi Fernando, This patch is introducing rproc_trigger_recover function which is in charge of recovering the rproc. One way to recover the rproc after a crash is resetting all its virtio devices.

[PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-08 Thread Fernando Guzman Lugo
This patch is introducing rproc_trigger_recover function which is in charge of recovering the rproc. One way to recover the rproc after a crash is resetting all its virtio devices. Doing that, all rpmsg drivers are restored along with the rpmsg devices and that also causes the reset of the

[PATCH 2/3] remoteproc: recover a remoteproc when it has crashed

2012-08-08 Thread Fernando Guzman Lugo
This patch is introducing rproc_trigger_recover function which is in charge of recovering the rproc. One way to recover the rproc after a crash is resetting all its virtio devices. Doing that, all rpmsg drivers are restored along with the rpmsg devices and that also causes the reset of the