Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2021-01-04 Thread Vivek Goyal
On Wed, Dec 23, 2020 at 07:48:52AM -0500, Jeff Layton wrote: > On Mon, 2020-12-21 at 14:50 -0500, Vivek Goyal wrote: > > Right now we check for errors on super block in syncfs(). > > > > ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); > > > > overlayfs does not update sb->s_wb_err and it

Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2020-12-23 Thread Jeff Layton
On Mon, 2020-12-21 at 14:50 -0500, Vivek Goyal wrote: > Right now we check for errors on super block in syncfs(). > > ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); > > overlayfs does not update sb->s_wb_err and it is tracked on upper filesystem. > So provide a superblock operation to

Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2020-12-23 Thread Jeff Layton
On Tue, 2020-12-22 at 11:25 -0500, Vivek Goyal wrote: > On Tue, Dec 22, 2020 at 04:19:00PM +, Matthew Wilcox wrote: > > On Mon, Dec 21, 2020 at 02:50:54PM -0500, Vivek Goyal wrote: > > > - ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); > > > + if (sb->s_op->errseq_check_advance) > > >

Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2020-12-22 Thread Vivek Goyal
On Tue, Dec 22, 2020 at 04:19:00PM +, Matthew Wilcox wrote: > On Mon, Dec 21, 2020 at 02:50:54PM -0500, Vivek Goyal wrote: > > - ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); > > + if (sb->s_op->errseq_check_advance) > > + ret2 = sb->s_op->errseq_check_advance(sb,

Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2020-12-22 Thread Matthew Wilcox
On Mon, Dec 21, 2020 at 02:50:54PM -0500, Vivek Goyal wrote: > - ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); > + if (sb->s_op->errseq_check_advance) > + ret2 = sb->s_op->errseq_check_advance(sb, f.file); What a terrible name for an fs operation. You don't seem to

[PATCH 2/3] vfs: Add a super block operation to check for writeback errors

2020-12-21 Thread Vivek Goyal
Right now we check for errors on super block in syncfs(). ret2 = errseq_check_and_advance(>s_wb_err, >f_sb_err); overlayfs does not update sb->s_wb_err and it is tracked on upper filesystem. So provide a superblock operation to check errors so that filesystem can provide override generic method