From: Matthew Wilcox <[EMAIL PROTECTED]>
Date: Wed, 26 Sep 2007 15:01:17 -0400
> Check that 'align' is a power of two, like the API specifies.
> Align 'size' to 'align' correctly -- the current code has an off-by-one.
> The ALIGN macro in kernel.h doesn't.
>
> Signed-off-by: Matthew Wilcox
Matthew Wilcox wrote:
> On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote:
>> The brackets in the first if/else are not required, and you could combine
>> the two statements:
>
> You mean braces, not brackets. And I find this little fetish of yours
> highly disturbing. I prefer to use
Matthew Wilcox wrote:
> Check that 'align' is a power of two, like the API specifies.
> Align 'size' to 'align' correctly -- the current code has an off-by-one.
> The ALIGN macro in kernel.h doesn't.
>
> Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
> ---
> mm/dmapool.c | 15
Check that 'align' is a power of two, like the API specifies.
Align 'size' to 'align' correctly -- the current code has an off-by-one.
The ALIGN macro in kernel.h doesn't.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
mm/dmapool.c | 15 ---
1 files changed, 8 insertions(+),
Check that 'align' is a power of two, like the API specifies.
Align 'size' to 'align' correctly -- the current code has an off-by-one.
The ALIGN macro in kernel.h doesn't.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
mm/dmapool.c | 15 ---
1 files changed, 8 insertions(+), 7
Matthew Wilcox wrote:
Check that 'align' is a power of two, like the API specifies.
Align 'size' to 'align' correctly -- the current code has an off-by-one.
The ALIGN macro in kernel.h doesn't.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
mm/dmapool.c | 15 ---
1
Matthew Wilcox wrote:
On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote:
The brackets in the first if/else are not required, and you could combine
the two statements:
You mean braces, not brackets. And I find this little fetish of yours
highly disturbing. I prefer to use braces, and
From: Matthew Wilcox [EMAIL PROTECTED]
Date: Wed, 26 Sep 2007 15:01:17 -0400
Check that 'align' is a power of two, like the API specifies.
Align 'size' to 'align' correctly -- the current code has an off-by-one.
The ALIGN macro in kernel.h doesn't.
Signed-off-by: Matthew Wilcox [EMAIL
8 matches
Mail list logo