Re: [PATCH 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
> Agreed, I also was going to say the same, about the flags. Please review the updated version I just sent out. Christian

Re: [PATCH 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Mon, Mar 25, 2019 at 07:18:42PM +0100, Jann Horn wrote: > On Mon, Mar 25, 2019 at 5:21 PM Christian Brauner > wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > > picked up by

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Christian Brauner
On Mon, Mar 25, 2019 at 05:20:54PM +, Mika Penttilä wrote: > Hi! > > > > +SYSCALL_DEFINE5(pidctl, unsigned int, cmd, pid_t, pid, int, source, int, > > target, > > + unsigned int, flags) > > +{ > > + struct pid_namespace *source_ns = NULL, *target_ns = NULL; > > + struct pid

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Christian Brauner
On Mon, Mar 25, 2019 at 07:18:42PM +0100, Jann Horn wrote: > On Mon, Mar 25, 2019 at 5:21 PM Christian Brauner > wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > > picked up by

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Jann Horn
On Mon, Mar 25, 2019 at 5:21 PM Christian Brauner wrote: > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is preserved in this > syscall:

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Mika Penttilä
Hi! > +SYSCALL_DEFINE5(pidctl, unsigned int, cmd, pid_t, pid, int, source, int, > target, > + unsigned int, flags) > +{ > + struct pid_namespace *source_ns = NULL, *target_ns = NULL; > + struct pid *struct_pid; > + pid_t result; > + > + switch (cmd) { > + case

[PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Christian Brauner
The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. I quote Konstantins original patchset first that has already been acked and picked up by Eric before and whose functionality is preserved in this syscall: "Each process have different pids, one for each pid namespace it