Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

On Mon, 2017-10-16 at 16:17 +0800, Sean Wang wrote: > Hi Alexandre, > > Thanks for your valuable suggestions on the driver. > > I added comments inline and will have following-ups in the next version > > Sean > > On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > > Hi, > > >

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

On Mon, 2017-10-16 at 16:17 +0800, Sean Wang wrote: > Hi Alexandre, > > Thanks for your valuable suggestions on the driver. > > I added comments inline and will have following-ups in the next version > > Sean > > On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > > Hi, > > >

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

Hi Alexandre, Thanks for your valuable suggestions on the driver. I added comments inline and will have following-ups in the next version Sean On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > Hi, > > On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote: > > diff

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

Hi Alexandre, Thanks for your valuable suggestions on the driver. I added comments inline and will have following-ups in the next version Sean On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > Hi, > > On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote: > > diff

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

Hi, On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote: > diff --git a/drivers/rtc/rtc-mediatek.c b/drivers/rtc/rtc-mediatek.c I'm pretty sure this should be named rtc-mt7622.c instead of rtc-mediatek.c, exactly for the same reason you have patch 3/4. > +static void mtk_w32(struct

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

Hi, On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote: > diff --git a/drivers/rtc/rtc-mediatek.c b/drivers/rtc/rtc-mediatek.c I'm pretty sure this should be named rtc-mt7622.c instead of rtc-mediatek.c, exactly for the same reason you have patch 3/4. > +static void mtk_w32(struct

[PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

From: Sean Wang This patch introduces the driver for the RTC on MT7622 SoC. Signed-off-by: Sean Wang --- drivers/rtc/Kconfig| 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mediatek.c | 398

[PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

From: Sean Wang This patch introduces the driver for the RTC on MT7622 SoC. Signed-off-by: Sean Wang --- drivers/rtc/Kconfig| 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mediatek.c | 398 + 3 files changed, 409 insertions(+)