Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread DaeSeok Youn
Hi, Dan 2014-05-26 19:50 GMT+09:00 Dan Carpenter : > On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: >> When dgap_tty_init() and dgap_tty_register_ports() are failed, >> these are needed to free some memory properly. >> >> It can be handled by calling dgap_tty_uninit() and

Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread Dan Carpenter
On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: > When dgap_tty_init() and dgap_tty_register_ports() are failed, > these are needed to free some memory properly. > > It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). > But tty's ports are not registered yet

[PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread Daeseok Youn
When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). But tty's ports are not registered yet when these function are failed, so brd->nasync set to zero. Signed-off-by:

[PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread Daeseok Youn
When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). But tty's ports are not registered yet when these function are failed, so brd-nasync set to zero. Signed-off-by:

Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread Dan Carpenter
On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). But tty's ports are not registered yet when

Re: [PATCH 2/4] staging: dgap: implement proper error handling in dgap_firmware_load()

2014-05-26 Thread DaeSeok Youn
Hi, Dan 2014-05-26 19:50 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote: When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling