Re: [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-25 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Tue, Nov 24, 2020 at 3:43 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Tue, Nov 24, 2020 at 12:27 PM Lad Prabhakar > wrote: > > Define rpcif_enable_rpm() and rpcif_disable_rpm() as static > > inline in the header instead of exporting it. > > > >

Re: [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-24 Thread Sergei Shtylyov
Hello! On 11/24/20 2:25 PM, Lad Prabhakar wrote: > Define rpcif_enable_rpm() and rpcif_disable_rpm() as static Not sure why I didn't do it this way myself... > inline in the header instead of exporting it. s/it/them/. > Suggested-by: Pavel Machek > Signed-off-by: Lad Prabhakar > ---

Re: [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-24 Thread Geert Uytterhoeven
Hi Prabhakar, On Tue, Nov 24, 2020 at 12:27 PM Lad Prabhakar wrote: > Define rpcif_enable_rpm() and rpcif_disable_rpm() as static > inline in the header instead of exporting it. > > Suggested-by: Pavel Machek > Signed-off-by: Lad Prabhakar Thanks for your patch, which is an improvement. >

[PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-24 Thread Lad Prabhakar
Define rpcif_enable_rpm() and rpcif_disable_rpm() as static inline in the header instead of exporting it. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/memory/renesas-rpc-if.c | 13 - include/memory/renesas-rpc-if.h | 13 +++-- 2 files changed, 11