Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >> ps: can you point me to your devices shipping with f_midi ? Which >> architecture are they using ? Which USB Peripheral Controller ? This >> might be a good addition to my test farm depending on your answers above >> :-p > > Seaboard

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >> ps: can you point me to your devices shipping with f_midi ? Which >> architecture are they using ? Which USB Peripheral Controller ? This >> might be a good addition to my test farm depending on your answers above >> :-p > > Seaboard GRAND[1]. Freescale's

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Ferreri Tonello
Hi Balbi, On 08/03/16 14:01, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: Since f_midi_transmit is called by both ALSA and USB frameworks, it >>> can potentially cause a race condition between both calls. This is bad >>>

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Ferreri Tonello
Hi Balbi, On 08/03/16 14:01, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: Since f_midi_transmit is called by both ALSA and USB frameworks, it >>> can potentially cause a race condition between both calls. This is bad >>> because the way

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >>> Since f_midi_transmit is called by both ALSA and USB frameworks, it >> can >>> potentially cause a race condition between both calls. This is bad >> because the >>> way f_midi_transmit is implemented can't handle

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >>> Since f_midi_transmit is called by both ALSA and USB frameworks, it >> can >>> potentially cause a race condition between both calls. This is bad >> because the >>> way f_midi_transmit is implemented can't handle concurrent calls.

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Ferreri Tonello
Hi Balbi, On 08/03/16 07:37, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >> Since f_midi_transmit is called by both ALSA and USB frameworks, it > can >> potentially cause a race condition between both calls. This is bad > because the

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-08 Thread Felipe Ferreri Tonello
Hi Balbi, On 08/03/16 07:37, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >> Since f_midi_transmit is called by both ALSA and USB frameworks, it > can >> potentially cause a race condition between both calls. This is bad > because the >> way

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-07 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: > Since f_midi_transmit is called by both ALSA and USB frameworks, it can > potentially cause a race condition between both calls. This is bad because the > way f_midi_transmit is implemented can't handle

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-07 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: > Since f_midi_transmit is called by both ALSA and USB frameworks, it can > potentially cause a race condition between both calls. This is bad because the > way f_midi_transmit is implemented can't handle concurrent calls. This is

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-07 Thread Felipe Ferreri Tonello
Hi Balbi, On 07/03/16 07:32, Felipe Balbi wrote: > > Hi, > > (please break your lines at 80-characters, have a look at > Documentation/email-clients.txt if needed) > > Felipe Ferreri Tonello writes: >> [ text/plain ] >> Hi Balbi, >> >> On March 4, 2016 7:20:10 AM

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-07 Thread Felipe Ferreri Tonello
Hi Balbi, On 07/03/16 07:32, Felipe Balbi wrote: > > Hi, > > (please break your lines at 80-characters, have a look at > Documentation/email-clients.txt if needed) > > Felipe Ferreri Tonello writes: >> [ text/plain ] >> Hi Balbi, >> >> On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-06 Thread Felipe Balbi
Hi, (please break your lines at 80-characters, have a look at Documentation/email-clients.txt if needed) Felipe Ferreri Tonello writes: > [ text/plain ] > Hi Balbi, > > On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote: >> >>Hi, >> >>"Felipe

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-06 Thread Felipe Balbi
Hi, (please break your lines at 80-characters, have a look at Documentation/email-clients.txt if needed) Felipe Ferreri Tonello writes: > [ text/plain ] > Hi Balbi, > > On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote: >> >>Hi, >> >>"Felipe F. Tonello" writes: >>> [ text/plain ]

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-04 Thread Felipe Ferreri Tonello
Hi Balbi, On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote: > >Hi, > >"Felipe F. Tonello" writes: >> [ text/plain ] >> Since f_midi_transmit is called by both ALSA and USB frameworks, it >can >> potentially cause a race condition between both

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-04 Thread Felipe Ferreri Tonello
Hi Balbi, On March 4, 2016 7:20:10 AM GMT+00:00, Felipe Balbi wrote: > >Hi, > >"Felipe F. Tonello" writes: >> [ text/plain ] >> Since f_midi_transmit is called by both ALSA and USB frameworks, it >can >> potentially cause a race condition between both calls. This is bad >because the >> way

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-03 Thread Felipe Balbi
Hi, "Felipe F. Tonello" writes: > [ text/plain ] > Since f_midi_transmit is called by both ALSA and USB frameworks, it can > potentially cause a race condition between both calls. This is bad because the > way f_midi_transmit is implemented can't handle concurrent calls.

Re: [PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-03 Thread Felipe Balbi
Hi, "Felipe F. Tonello" writes: > [ text/plain ] > Since f_midi_transmit is called by both ALSA and USB frameworks, it can > potentially cause a race condition between both calls. This is bad because the > way f_midi_transmit is implemented can't handle concurrent calls. This is due > to the

[PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-02 Thread Felipe F. Tonello
Since f_midi_transmit is called by both ALSA and USB frameworks, it can potentially cause a race condition between both calls. This is bad because the way f_midi_transmit is implemented can't handle concurrent calls. This is due to the fact that the usb request fifo looks for the next element and

[PATCH 2/5] usb: gadget: f_midi: added spinlock on transmit function

2016-03-02 Thread Felipe F. Tonello
Since f_midi_transmit is called by both ALSA and USB frameworks, it can potentially cause a race condition between both calls. This is bad because the way f_midi_transmit is implemented can't handle concurrent calls. This is due to the fact that the usb request fifo looks for the next element and