Re: [PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Nicolas Ferre
On 11/16/2012 02:59 PM, Andy Shevchenko : > dma_transfer_direction is a normal enum. It means we can't usually use the > values as bit fields. Let's adjust this check and move it above the usage of > the direction parameter. > > Signed-off-by: Andy Shevchenko > Cc: Nicolas Ferre Whatever name

Re: [PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Viresh Kumar
On 16 November 2012 19:29, Andy Shevchenko wrote: > dma_transfer_direction is a normal enum. It means we can't usually use the > values as bit fields. Let's adjust this check and move it above the usage of > the direction parameter. > > Signed-off-by: Andy Shevchenko > Cc: Nicolas Ferre

[PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko Cc: Nicolas Ferre --- drivers/dma/at_hdmac.c | 10 +- 1 file changed, 5

[PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Andy Shevchenko
dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Nicolas Ferre nicolas.fe...@atmel.com ---

Re: [PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Viresh Kumar
On 16 November 2012 19:29, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko

Re: [PATCH 2/6] dma: at_hdmac: check direction properly for cyclic transfers

2012-11-16 Thread Nicolas Ferre
On 11/16/2012 02:59 PM, Andy Shevchenko : dma_transfer_direction is a normal enum. It means we can't usually use the values as bit fields. Let's adjust this check and move it above the usage of the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: