Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Minchan Kim
Hi Mel, On Fri, Aug 10, 2012 at 09:34:38AM +0100, Mel Gorman wrote: > On Fri, Aug 10, 2012 at 08:27:33AM +0900, Minchan Kim wrote: > > > > > > > > > The intention is that an allocation can fail but each subsequent attempt > > > will > > > try harder until there is success. Each allocation

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Mel Gorman
On Fri, Aug 10, 2012 at 08:27:33AM +0900, Minchan Kim wrote: > > > > > > The intention is that an allocation can fail but each subsequent attempt > > will > > try harder until there is success. Each allocation request does a portion > > of the necessary work to spread the cost between multiple

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Mel Gorman
On Thu, Aug 09, 2012 at 04:29:57PM -0400, Rik van Riel wrote: > On 08/09/2012 05:20 AM, Mel Gorman wrote: > > >The intention is that an allocation can fail but each subsequent attempt will > >try harder until there is success. Each allocation request does a portion > >of the necessary work to

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Mel Gorman
On Thu, Aug 09, 2012 at 04:29:57PM -0400, Rik van Riel wrote: On 08/09/2012 05:20 AM, Mel Gorman wrote: The intention is that an allocation can fail but each subsequent attempt will try harder until there is success. Each allocation request does a portion of the necessary work to spread the

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Mel Gorman
On Fri, Aug 10, 2012 at 08:27:33AM +0900, Minchan Kim wrote: SNIP The intention is that an allocation can fail but each subsequent attempt will try harder until there is success. Each allocation request does a portion of the necessary work to spread the cost between multiple requests.

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-10 Thread Minchan Kim
Hi Mel, On Fri, Aug 10, 2012 at 09:34:38AM +0100, Mel Gorman wrote: On Fri, Aug 10, 2012 at 08:27:33AM +0900, Minchan Kim wrote: SNIP The intention is that an allocation can fail but each subsequent attempt will try harder until there is success. Each allocation request does a

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Minchan Kim
On Thu, Aug 09, 2012 at 10:20:35AM +0100, Mel Gorman wrote: > On Thu, Aug 09, 2012 at 05:27:15PM +0900, Minchan Kim wrote: > > > > > + * pages reclaimed based on the number of consecutive allocation > > > > > + * failures > > > > > + */ > > > > > + zone = lruvec_zone(lruvec); >

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Rik van Riel
On 08/09/2012 05:20 AM, Mel Gorman wrote: The intention is that an allocation can fail but each subsequent attempt will try harder until there is success. Each allocation request does a portion of the necessary work to spread the cost between multiple requests. At some point we need to stop

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Mel Gorman
On Thu, Aug 09, 2012 at 05:27:15PM +0900, Minchan Kim wrote: > > > > + * pages reclaimed based on the number of consecutive allocation > > > > + * failures > > > > + */ > > > > + zone = lruvec_zone(lruvec); > > > > + if (zone->compact_order_failed >= sc->order) > > > > > >

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Minchan Kim
On Thu, Aug 09, 2012 at 08:49:50AM +0100, Mel Gorman wrote: > On Thu, Aug 09, 2012 at 08:51:27AM +0900, Minchan Kim wrote: > > > > > > Just out of curiosity. > > > > > > What's the problem did you see? (ie, What's the problem do this > > > > > > patch solve?) > > > > > > > > > > Everythign in

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Mel Gorman
On Thu, Aug 09, 2012 at 08:51:27AM +0900, Minchan Kim wrote: > > > > > Just out of curiosity. > > > > > What's the problem did you see? (ie, What's the problem do this patch > > > > > solve?) > > > > > > > > Everythign in this series is related to the problem in the leader - high > > > > order

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Mel Gorman
On Thu, Aug 09, 2012 at 08:51:27AM +0900, Minchan Kim wrote: Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) Everythign in this series is related to the problem in the leader - high order allocation success rates are

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Minchan Kim
On Thu, Aug 09, 2012 at 08:49:50AM +0100, Mel Gorman wrote: On Thu, Aug 09, 2012 at 08:51:27AM +0900, Minchan Kim wrote: Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) Everythign in this series is related to the

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Mel Gorman
On Thu, Aug 09, 2012 at 05:27:15PM +0900, Minchan Kim wrote: + * pages reclaimed based on the number of consecutive allocation + * failures + */ + zone = lruvec_zone(lruvec); + if (zone-compact_order_failed = sc-order) I can't understand this part.

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Rik van Riel
On 08/09/2012 05:20 AM, Mel Gorman wrote: The intention is that an allocation can fail but each subsequent attempt will try harder until there is success. Each allocation request does a portion of the necessary work to spread the cost between multiple requests. At some point we need to stop

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-09 Thread Minchan Kim
On Thu, Aug 09, 2012 at 10:20:35AM +0100, Mel Gorman wrote: On Thu, Aug 09, 2012 at 05:27:15PM +0900, Minchan Kim wrote: + * pages reclaimed based on the number of consecutive allocation + * failures + */ + zone = lruvec_zone(lruvec); + if

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Minchan Kim
On Wed, Aug 08, 2012 at 09:51:12AM +0100, Mel Gorman wrote: > On Wed, Aug 08, 2012 at 05:27:38PM +0900, Minchan Kim wrote: > > On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: > > > On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: > > > > Hi Mel, > > > > > > > > Just out of

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Mel Gorman
On Wed, Aug 08, 2012 at 05:27:38PM +0900, Minchan Kim wrote: > On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: > > On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: > > > Hi Mel, > > > > > > Just out of curiosity. > > > What's the problem did you see? (ie, What's the

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Minchan Kim
On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: > On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: > > Hi Mel, > > > > Just out of curiosity. > > What's the problem did you see? (ie, What's the problem do this patch > > solve?) > > Everythign in this series is related to

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Mel Gorman
On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: > Hi Mel, > > Just out of curiosity. > What's the problem did you see? (ie, What's the problem do this patch solve?) Everythign in this series is related to the problem in the leader - high order allocation success rates are lower.

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Mel Gorman
On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: Hi Mel, Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) Everythign in this series is related to the problem in the leader - high order allocation success rates are lower. This

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Minchan Kim
On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: Hi Mel, Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) Everythign in this series is related to the problem

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Mel Gorman
On Wed, Aug 08, 2012 at 05:27:38PM +0900, Minchan Kim wrote: On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: Hi Mel, Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-08 Thread Minchan Kim
On Wed, Aug 08, 2012 at 09:51:12AM +0100, Mel Gorman wrote: On Wed, Aug 08, 2012 at 05:27:38PM +0900, Minchan Kim wrote: On Wed, Aug 08, 2012 at 08:55:26AM +0100, Mel Gorman wrote: On Wed, Aug 08, 2012 at 10:48:24AM +0900, Minchan Kim wrote: Hi Mel, Just out of curiosity.

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Minchan Kim
Hi Mel, Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) AFAIUC, it seem to solve consecutive allocation success ratio through getting several free pageblocks all at once in a process/kswapd reclaim context. Right? On Tue, Aug 07, 2012 at

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Rik van Riel
On 08/07/2012 08:31 AM, Mel Gorman wrote: If allocation fails after compaction then compaction may be deferred for a number of allocation attempts. If there are subsequent failures, compact_defer_shift is increased to defer for longer periods. This patch uses that information to scale the number

[PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Mel Gorman
If allocation fails after compaction then compaction may be deferred for a number of allocation attempts. If there are subsequent failures, compact_defer_shift is increased to defer for longer periods. This patch uses that information to scale the number of pages reclaimed with compact_defer_shift

[PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Mel Gorman
If allocation fails after compaction then compaction may be deferred for a number of allocation attempts. If there are subsequent failures, compact_defer_shift is increased to defer for longer periods. This patch uses that information to scale the number of pages reclaimed with compact_defer_shift

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Rik van Riel
On 08/07/2012 08:31 AM, Mel Gorman wrote: If allocation fails after compaction then compaction may be deferred for a number of allocation attempts. If there are subsequent failures, compact_defer_shift is increased to defer for longer periods. This patch uses that information to scale the number

Re: [PATCH 2/6] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures

2012-08-07 Thread Minchan Kim
Hi Mel, Just out of curiosity. What's the problem did you see? (ie, What's the problem do this patch solve?) AFAIUC, it seem to solve consecutive allocation success ratio through getting several free pageblocks all at once in a process/kswapd reclaim context. Right? On Tue, Aug 07, 2012 at