Re: [PATCH 2/7] mm: Rewrite shmem_seek_hole_data

2020-08-20 Thread Matthew Wilcox
On Thu, Aug 20, 2020 at 07:45:46PM +0300, Mike Rapoport wrote: > > - * llseek SEEK_DATA or SEEK_HOLE through the page cache. > > + * llseek SEEK_DATA or SEEK_HOLE through the page cache. We don't need > > + * to get a reference on the page because this interface is racy anyway. > > + * The page

Re: [PATCH 2/7] mm: Rewrite shmem_seek_hole_data

2020-08-20 Thread Mike Rapoport
On Wed, Aug 19, 2020 at 04:05:50PM +0100, Matthew Wilcox (Oracle) wrote: > use the XArray directly instead of using the pagevec abstraction. > The code is simpler and more efficient. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/shmem.c | 61

[PATCH 2/7] mm: Rewrite shmem_seek_hole_data

2020-08-19 Thread Matthew Wilcox (Oracle)
use the XArray directly instead of using the pagevec abstraction. The code is simpler and more efficient. Signed-off-by: Matthew Wilcox (Oracle) --- mm/shmem.c | 61 +- 1 file changed, 24 insertions(+), 37 deletions(-) diff --git a/mm/shmem.c