Arjan van de Ven wrote:
Hi,
your code looks very nice and clean, only few comments, see below
Thanks
+static int mdps_joystick_kthread(void *data)
+{
+ int x = 0, y = 0, z = 0;
+
+ while (!kthread_should_stop()) {
+ if (input_3d) {
+
Arjan van de Ven wrote:
Hi,
your code looks very nice and clean, only few comments, see below
Thanks
+static int mdps_joystick_kthread(void *data)
+{
+ int x = 0, y = 0, z = 0;
+
+ while (!kthread_should_stop()) {
+ if (input_3d) {
+
Hi,
your code looks very nice and clean, only few comments, see below
> +static int mdps_joystick_kthread(void *data)
> +{
> + int x = 0, y = 0, z = 0;
> +
> + while (!kthread_should_stop()) {
> + if (input_3d) {
> + mdps_get_xyz(mdps.device->handle, , ,
Dmitry Torokhov wrote:
Hi Yan,
On 3/23/07, Yan Burman <[EMAIL PROTECTED]> wrote:
+
+static unsigned int input_3d;
+module_param(input_3d, bool, S_IRUGO);
+MODULE_PARM_DESC(input_3d, "Operate as a 3D joystick instead of 2D");
Why do you need that? Just have the driver always report all 3
Hi Yan,
On 3/23/07, Yan Burman <[EMAIL PROTECTED]> wrote:
+
+static unsigned int input_3d;
+module_param(input_3d, bool, S_IRUGO);
+MODULE_PARM_DESC(input_3d, "Operate as a 3D joystick instead of 2D");
Why do you need that? Just have the driver always report all 3 events
and have applications
HP Mobile Data Protection System 3D ACPI driver. Similar to hdaps in
functionality.
This driver provides 4 kinds of functionality:
1) Creates a misc device /dev/accel that acts similar to /dev/rtc and unblocks
the process reading from it when the device detects free-fall interrupt
2) Functions as
HP Mobile Data Protection System 3D ACPI driver. Similar to hdaps in
functionality.
This driver provides 4 kinds of functionality:
1) Creates a misc device /dev/accel that acts similar to /dev/rtc and unblocks
the process reading from it when the device detects free-fall interrupt
2) Functions as
Hi Yan,
On 3/23/07, Yan Burman [EMAIL PROTECTED] wrote:
+
+static unsigned int input_3d;
+module_param(input_3d, bool, S_IRUGO);
+MODULE_PARM_DESC(input_3d, Operate as a 3D joystick instead of 2D);
Why do you need that? Just have the driver always report all 3 events
and have applications
Dmitry Torokhov wrote:
Hi Yan,
On 3/23/07, Yan Burman [EMAIL PROTECTED] wrote:
+
+static unsigned int input_3d;
+module_param(input_3d, bool, S_IRUGO);
+MODULE_PARM_DESC(input_3d, Operate as a 3D joystick instead of 2D);
Why do you need that? Just have the driver always report all 3 events
Hi,
your code looks very nice and clean, only few comments, see below
+static int mdps_joystick_kthread(void *data)
+{
+ int x = 0, y = 0, z = 0;
+
+ while (!kthread_should_stop()) {
+ if (input_3d) {
+ mdps_get_xyz(mdps.device-handle, x, y, z);
+
10 matches
Mail list logo
