Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:12 PM, Lee Jones wrote: > At the moment we fetch the hardware revision, then do some stuff, then > check whether the revision is correct and return in error if it's not. > Well we may as well check it as soon as we know what it is, so let's > move the check right up

Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:12 PM, Lee Jones lee.jo...@linaro.org wrote: At the moment we fetch the hardware revision, then do some stuff, then check whether the revision is correct and return in error if it's not. Well we may as well check it as soon as we know what it is, so let's move the

Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:12:02AM +0100, Lee Jones wrote: > At the moment we fetch the hardware revision, then do some stuff, then > check whether the revision is correct and return in error if it's not. > Well we may as well check it as soon as we know what it is, so let's > move the check right

Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:12:02AM +0100, Lee Jones wrote: At the moment we fetch the hardware revision, then do some stuff, then check whether the revision is correct and return in error if it's not. Well we may as well check it as soon as we know what it is, so let's move the check right up

[PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-18 Thread Lee Jones
At the moment we fetch the hardware revision, then do some stuff, then check whether the revision is correct and return in error if it's not. Well we may as well check it as soon as we know what it is, so let's move the check right up underneath where we acquire the version. Cc: Vinod Koul Cc:

[PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition

2013-04-18 Thread Lee Jones
At the moment we fetch the hardware revision, then do some stuff, then check whether the revision is correct and return in error if it's not. Well we may as well check it as soon as we know what it is, so let's move the check right up underneath where we acquire the version. Cc: Vinod Koul