On Wed, 2013-04-10 at 10:30 +0900, Namhyung Kim wrote:
> >From 7ba245dba217ef858b467552019acd49f7fdce7e Mon Sep 17 00:00:00 2001
> From: Namhyung Kim
> Date: Wed, 10 Apr 2013 09:10:44 +0900
> Subject: [PATCH] tracing: Check result of ring_buffer_read_prepare()
>
> The ring_buffer_read_prepare()
On Tue, 09 Apr 2013 20:46:27 -0400, Steven Rostedt wrote:
> On Wed, 2013-04-10 at 09:36 +0900, Namhyung Kim wrote:
>
>> You meant iter->cpu_file != RING_BUFFER_ALL_CPUS case, right?
>
> Yep.
>
>>
>> So why bother trying to check other cpus then?
>
> Because it's a very slow path (closing a file),
On Wed, 2013-04-10 at 09:36 +0900, Namhyung Kim wrote:
> You meant iter->cpu_file != RING_BUFFER_ALL_CPUS case, right?
Yep.
>
> So why bother trying to check other cpus then?
Because it's a very slow path (closing a file), and it keeps the code
simpler and more condense.
We could add your
Hi Steve,
2013-04-10 오전 9:31, Steven Rostedt 쓴 글:
On Wed, 2013-04-10 at 09:18 +0900, Namhyung Kim wrote:
From: Namhyung Kim
It looks like tracing_release() lacks checking iter->cpu_file so that
closing a per_cpu trace file would attempt to close all cpu buffers.
Signed-off-by: Namhyung Kim
On Wed, 2013-04-10 at 09:18 +0900, Namhyung Kim wrote:
> From: Namhyung Kim
>
> It looks like tracing_release() lacks checking iter->cpu_file so that
> closing a per_cpu trace file would attempt to close all cpu buffers.
>
> Signed-off-by: Namhyung Kim
> ---
> kernel/trace/trace.c | 8
From: Namhyung Kim
It looks like tracing_release() lacks checking iter->cpu_file so that
closing a per_cpu trace file would attempt to close all cpu buffers.
Signed-off-by: Namhyung Kim
---
kernel/trace/trace.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
From: Namhyung Kim namhyung@lge.com
It looks like tracing_release() lacks checking iter-cpu_file so that
closing a per_cpu trace file would attempt to close all cpu buffers.
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
kernel/trace/trace.c | 8 +++-
1 file changed, 7
On Wed, 2013-04-10 at 09:18 +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
It looks like tracing_release() lacks checking iter-cpu_file so that
closing a per_cpu trace file would attempt to close all cpu buffers.
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
Hi Steve,
2013-04-10 오전 9:31, Steven Rostedt 쓴 글:
On Wed, 2013-04-10 at 09:18 +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
It looks like tracing_release() lacks checking iter-cpu_file so that
closing a per_cpu trace file would attempt to close all cpu buffers.
On Wed, 2013-04-10 at 09:36 +0900, Namhyung Kim wrote:
You meant iter-cpu_file != RING_BUFFER_ALL_CPUS case, right?
Yep.
So why bother trying to check other cpus then?
Because it's a very slow path (closing a file), and it keeps the code
simpler and more condense.
We could add your change
On Tue, 09 Apr 2013 20:46:27 -0400, Steven Rostedt wrote:
On Wed, 2013-04-10 at 09:36 +0900, Namhyung Kim wrote:
You meant iter-cpu_file != RING_BUFFER_ALL_CPUS case, right?
Yep.
So why bother trying to check other cpus then?
Because it's a very slow path (closing a file), and it keeps
On Wed, 2013-04-10 at 10:30 +0900, Namhyung Kim wrote:
From 7ba245dba217ef858b467552019acd49f7fdce7e Mon Sep 17 00:00:00 2001
From: Namhyung Kim namhyung@lge.com
Date: Wed, 10 Apr 2013 09:10:44 +0900
Subject: [PATCH] tracing: Check result of ring_buffer_read_prepare()
The
12 matches
Mail list logo