Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Wed, 26 Sep 2007 15:01:18 -0400 > Also add documentation for how dma pools work, move the header above the > includes, add my copyright, add the original author's copyright, add a > GPL v2 licence to the file and fix the includes. > > Signed-off-by:

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread roel
Matthew Wilcox wrote: [...] > @@ -113,9 +133,12 @@ struct dma_pool *dma_pool_create(const char *name, > struct device *dev, > return NULL; > } > > - if (size == 0) > + if (size == 0) { > return NULL; > - > + } else if (size < 4) { > +

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Roland Dreier
> Also add documentation for how dma pools work, move the header above the > includes, add my copyright, add the original author's copyright, add a > GPL v2 licence to the file and fix the includes. The fact that you have all these other changes mixed in makes the main change very difficult to

[PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Matthew Wilcox
Also add documentation for how dma pools work, move the header above the includes, add my copyright, add the original author's copyright, add a GPL v2 licence to the file and fix the includes. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- mm/dmapool.c | 161

[PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Matthew Wilcox
Also add documentation for how dma pools work, move the header above the includes, add my copyright, add the original author's copyright, add a GPL v2 licence to the file and fix the includes. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- mm/dmapool.c | 161

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Roland Dreier
Also add documentation for how dma pools work, move the header above the includes, add my copyright, add the original author's copyright, add a GPL v2 licence to the file and fix the includes. The fact that you have all these other changes mixed in makes the main change very difficult to

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread roel
Matthew Wilcox wrote: [...] @@ -113,9 +133,12 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, return NULL; } - if (size == 0) + if (size == 0) { return NULL; - + } else if (size 4) { + size = 4; +

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread David Miller
From: Matthew Wilcox [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 15:01:18 -0400 Also add documentation for how dma pools work, move the header above the includes, add my copyright, add the original author's copyright, add a GPL v2 licence to the file and fix the includes. Signed-off-by: