Re: [Gta04-owner] [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-22 Thread NeilBrown
On Wed, 4 Mar 2015 07:54:41 +0100 "Dr. H. Nikolaus Schaller" wrote: > > Am 04.03.2015 um 07:35 schrieb NeilBrown : > > > On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek wrote: > > > >> Hi! > >> > >>> The twl4030 phy can measure, with low precision, the > >>> resistance-to-ground of the ID

Re: [Gta04-owner] [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-22 Thread NeilBrown
On Wed, 4 Mar 2015 07:54:41 +0100 Dr. H. Nikolaus Schaller h...@goldelico.com wrote: Am 04.03.2015 um 07:35 schrieb NeilBrown ne...@suse.de: On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek pa...@ucw.cz wrote: Hi! The twl4030 phy can measure, with low precision, the

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-04 Thread Pavel Machek
Hi! > > New /sys files should be documented somewhere...? > > Preferably with the code... > > > Does it make sense to change "440k" -> "440KOhm"? > > Interesting question. I prefer to avoid including units in files - bare > numbers is better. But there is no number to match "floating" unless

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-04 Thread Pavel Machek
Hi! New /sys files should be documented somewhere...? Preferably with the code... Does it make sense to change 440k - 440KOhm? Interesting question. I prefer to avoid including units in files - bare numbers is better. But there is no number to match floating unless I spell it out

Re: [Gta04-owner] [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-03 Thread Dr. H. Nikolaus Schaller
Am 04.03.2015 um 07:35 schrieb NeilBrown : > On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek wrote: > >> Hi! >> >>> The twl4030 phy can measure, with low precision, the >>> resistance-to-ground of the ID pin. >>> >>> Add a function to read the value, and export the result >>> via sysfs. >>>

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-03 Thread NeilBrown
On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek wrote: > Hi! > > > The twl4030 phy can measure, with low precision, the > > resistance-to-ground of the ID pin. > > > > Add a function to read the value, and export the result > > via sysfs. > > > > If the read fails, which it does sometimes, try

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-03 Thread NeilBrown
On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek pa...@ucw.cz wrote: Hi! The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. If the read fails, which it does sometimes, try

Re: [Gta04-owner] [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-03 Thread Dr. H. Nikolaus Schaller
Am 04.03.2015 um 07:35 schrieb NeilBrown ne...@suse.de: On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek pa...@ucw.cz wrote: Hi! The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs.

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-02 Thread Pavel Machek
Hi! > The twl4030 phy can measure, with low precision, the > resistance-to-ground of the ID pin. > > Add a function to read the value, and export the result > via sysfs. > > If the read fails, which it does sometimes, try again in 50msec. > > Signed-off-by: NeilBrown > --- >

Re: [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-02 Thread Pavel Machek
Hi! The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. If the read fails, which it does sometimes, try again in 50msec. Signed-off-by: NeilBrown ne...@suse.de ---

[PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-02-23 Thread NeilBrown
The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. If the read fails, which it does sometimes, try again in 50msec. Signed-off-by: NeilBrown --- drivers/phy/phy-twl4030-usb.c | 63

[PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-02-23 Thread NeilBrown
The twl4030 phy can measure, with low precision, the resistance-to-ground of the ID pin. Add a function to read the value, and export the result via sysfs. If the read fails, which it does sometimes, try again in 50msec. Signed-off-by: NeilBrown ne...@suse.de --- drivers/phy/phy-twl4030-usb.c