(2013/01/25 13:09), Sasha Levin wrote:
> As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this
> is simply way too confusing. It doesn't make sense that a function named
> check_[...]() would modify any of it's parameters.
>
> For example, that entire block within
(2013/01/25 13:09), Sasha Levin wrote:
As to arch_check_optimized_kprobe() and check_kprobe_address_safe(), this
is simply way too confusing. It doesn't make sense that a function named
check_[...]() would modify any of it's parameters.
For example, that entire block within
Hello Masami,
Thank you for your review!
My comments are below.
On 01/21/2013 06:49 AM, Masami Hiramatsu wrote:
> (2013/01/10 8:09), Sasha Levin wrote:
>> @@ -278,7 +278,7 @@ static int __kprobes can_optimize(unsigned long paddr)
>> }
>>
>> /* Check optimized_kprobe can actually be
Hello Masami,
Thank you for your review!
My comments are below.
On 01/21/2013 06:49 AM, Masami Hiramatsu wrote:
(2013/01/10 8:09), Sasha Levin wrote:
@@ -278,7 +278,7 @@ static int __kprobes can_optimize(unsigned long paddr)
}
/* Check optimized_kprobe can actually be optimized. */
(2013/01/10 8:09), Sasha Levin wrote:
> Constify the parameters of lookup functions.
>
> Signed-off-by: Sasha Levin
> ---
> arch/x86/kernel/kprobes-opt.c | 8
> kernel/kprobes.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git
(2013/01/10 8:09), Sasha Levin wrote:
Constify the parameters of lookup functions.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
---
arch/x86/kernel/kprobes-opt.c | 8
kernel/kprobes.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
Constify the parameters of lookup functions.
Signed-off-by: Sasha Levin
---
arch/x86/kernel/kprobes-opt.c | 8
kernel/kprobes.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/kprobes-opt.c b/arch/x86/kernel/kprobes-opt.c
index
Constify the parameters of lookup functions.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
---
arch/x86/kernel/kprobes-opt.c | 8
kernel/kprobes.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/kprobes-opt.c
8 matches
Mail list logo