DaeSeok Youn writes:
>>> - * match with board's first found interface, otherwise this
>>> is first
>>> - * found
>>> + * match with board's first found interface, otherwise this is
>>> + * fisrt found
>>^
>> I wonder
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn :
> I think line break is a solution
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
I think line
DaeSeok Youn daeseok.y...@gmail.com writes:
- * match with board's first found interface, otherwise this
is first
- * found
+ * match with board's first found interface, otherwise this is
+ * fisrt found
^
I wonder
I think line break is a solution about long line warning. And
replacing with hex_dump() is better than managing with another patch.
So I said this improvement is separated with another patch.
Just my opinion.
If I'm wrong, I try to change as Krzysztof's comment in same patch.
Thanks.
Daeseok
On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
> 2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa :
> > why not use some existing *hex_dump*() instead?
> OK. but this patch is only for fix line length over 80 characters,
> right? If it can be improved as your comment,
> it must be in another
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa :
> Daeseok Youn writes:
>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>
> This warning should be long gone IMHO. It does more harm than good.
>
>> unsigned char *ucp = (unsigned char *) >mfg_info.data;
Daeseok Youn writes:
> clean up checkpatch.pl warnings:
> WARNING: Line length over 80 characters
This warning should be long gone IMHO. It does more harm than good.
> unsigned char *ucp = (unsigned char *) >mfg_info.data;
>
> pr_info("eeprom[00]: %02x %02x %02x
Daeseok Youn daeseok.y...@gmail.com writes:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
This warning should be long gone IMHO. It does more harm than good.
unsigned char *ucp = (unsigned char *) hi-mfg_info.data;
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa khal...@piap.pl:
Daeseok Youn daeseok.y...@gmail.com writes:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
This warning should be long gone IMHO. It does more harm than good.
unsigned char *ucp =
On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa khal...@piap.pl:
why not use some existing *hex_dump*() instead?
OK. but this patch is only for fix line length over 80 characters,
right? If it can be improved as your comment,
it must be in
I think line break is a solution about long line warning. And
replacing with hex_dump() is better than managing with another patch.
So I said this improvement is separated with another patch.
Just my opinion.
If I'm wrong, I try to change as Krzysztof's comment in same patch.
Thanks.
Daeseok
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git
14 matches
Mail list logo
