Re: [PATCH 3/7] mm: Add an 'end' parameter to find_get_entries

2020-08-21 Thread Jan Kara
On Fri 21-08-20 17:33:06, Matthew Wilcox wrote: > On Fri, Aug 21, 2020 at 06:07:59PM +0200, Jan Kara wrote: > > On Wed 19-08-20 16:05:51, Matthew Wilcox (Oracle) wrote: > > > This simplifies the callers and leads to a more efficient implementation > > > since the XArray has this functionality

Re: [PATCH 3/7] mm: Add an 'end' parameter to find_get_entries

2020-08-21 Thread Matthew Wilcox
On Fri, Aug 21, 2020 at 06:07:59PM +0200, Jan Kara wrote: > On Wed 19-08-20 16:05:51, Matthew Wilcox (Oracle) wrote: > > This simplifies the callers and leads to a more efficient implementation > > since the XArray has this functionality already. > > > > Signed-off-by: Matthew Wilcox (Oracle) >

Re: [PATCH 3/7] mm: Add an 'end' parameter to find_get_entries

2020-08-21 Thread Jan Kara
On Wed 19-08-20 16:05:51, Matthew Wilcox (Oracle) wrote: > This simplifies the callers and leads to a more efficient implementation > since the XArray has this functionality already. > > Signed-off-by: Matthew Wilcox (Oracle) The patch looks good to me. Just I'd note that you could drop some:

Re: [PATCH 3/7] mm: Add an 'end' parameter to find_get_entries

2020-08-20 Thread Mike Rapoport
On Wed, Aug 19, 2020 at 04:05:51PM +0100, Matthew Wilcox (Oracle) wrote: > This simplifies the callers and leads to a more efficient implementation > since the XArray has this functionality already. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 4 ++-- >

[PATCH 3/7] mm: Add an 'end' parameter to find_get_entries

2020-08-19 Thread Matthew Wilcox (Oracle)
This simplifies the callers and leads to a more efficient implementation since the XArray has this functionality already. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 4 ++-- mm/filemap.c| 9 + mm/shmem.c | 10 -- mm/swap.c