Re: [PATCH 3.16 35/99] pxa168fb: Fix the function used to release some memory in an error handling path

2020-05-21 Thread Ben Hutchings
On Thu, 2020-05-21 at 16:31 +0200, Marion & Christophe JAILLET wrote: > Hi, > > sorry for the noise, I have messed up my > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ usage. > I thought I was looking at the 3.16.83 branch, but I was not. > > The patch looks good to me.

Re: [PATCH 3.16 35/99] pxa168fb: Fix the function used to release some memory in an error handling path

2020-05-21 Thread Marion & Christophe JAILLET
Hi, sorry for the noise, I have messed up my https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ usage. I thought I was looking at the 3.16.83 branch, but I was not. The patch looks good to me. CJ Le 21/05/2020 à 16:09, Marion & Christophe JAILLET a écrit : Hi, I don't think

Re: [PATCH 3.16 35/99] pxa168fb: Fix the function used to release some memory in an error handling path

2020-05-21 Thread Marion & Christophe JAILLET
Hi, I don't think that this one is applicable to 3.16.x The remove function and the error handling path of the probe function both use 'dma_free_wc'. I've not look in details, but it looks consistent and the patch would not apply as-is anyway. just my 2c. CJ Le 20/05/2020 à 16:14, Ben

[PATCH 3.16 35/99] pxa168fb: Fix the function used to release some memory in an error handling path

2020-05-20 Thread Ben Hutchings
3.16.84-rc1 review patch. If anyone has any objections, please let me know. -- From: Christophe JAILLET commit 3c911fe799d1c338d94b78e7182ad452c37af897 upstream. In the probe function, some resources are allocated using 'dma_alloc_wc()', they should be released with