Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-08-01 Thread maxime.ripard
Hi Kevin, On Thu, Aug 01, 2013 at 08:34:35AM +0800, kevin.z.m wrote: > > Ok, just so that we're on the same page, we have two oscillators running > > at 32kHz, the internal being always there, and the external that could > > or could not be there, and it's each different hardware block that can >

Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-08-01 Thread maxime.ripard
Hi Kevin, On Thu, Aug 01, 2013 at 08:34:35AM +0800, kevin.z.m wrote: Ok, just so that we're on the same page, we have two oscillators running at 32kHz, the internal being always there, and the external that could or could not be there, and it's each different hardware block that can be

Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread maxime.ripard
On Wed, Jul 31, 2013 at 08:10:32PM +0800, kevin.z.m wrote: > > How does one select either the internal or the external 32kHz > > oscillator? Is this done in software (I can't find any reference to that > > in the user manuals) or in hardware? > For A20, it should be in the Timer module, and

Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread maxime.ripard
Hi Kevin, On Wed, Jul 31, 2013 at 04:11:11PM +0800, kevin.z.m wrote: > Hi, Maxime, > > > The problem is a bit more complex than that. > > > On the A31, the losc clock is actually a mux between an external > > oscillator running at 32kHz, and the internal oscillator running at > > 667MHz, that

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread Emilio López
Hi, El 31/07/13 05:11, kevin.z.m escribió: > Hi, Maxime, > >> The problem is a bit more complex than that. > >> On the A31, the losc clock is actually a mux between an external >> oscillator running at 32kHz, and the internal oscillator running at >> 667MHz, that would be scaled down. > >>

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread Maxime Ripard
Hi Emilio, On Tue, Jul 30, 2013 at 10:36:46PM -0300, Emilio López wrote: > Hi Maxime, > > Overall this looks good to me, but I have some small comments: > > El 30/07/13 11:44, Maxime Ripard escribió: > > Now that the clock driver has support for the A31 clocks, we can add > > them to the DTSI

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread Maxime Ripard
Hi Emilio, On Tue, Jul 30, 2013 at 10:36:46PM -0300, Emilio López wrote: Hi Maxime, Overall this looks good to me, but I have some small comments: El 30/07/13 11:44, Maxime Ripard escribió: Now that the clock driver has support for the A31 clocks, we can add them to the DTSI and start

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread Emilio López
Hi, El 31/07/13 05:11, kevin.z.m escribió: Hi, Maxime, The problem is a bit more complex than that. On the A31, the losc clock is actually a mux between an external oscillator running at 32kHz, and the internal oscillator running at 667MHz, that would be scaled down. Support for

Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread maxime.ripard
Hi Kevin, On Wed, Jul 31, 2013 at 04:11:11PM +0800, kevin.z.m wrote: Hi, Maxime, The problem is a bit more complex than that. On the A31, the losc clock is actually a mux between an external oscillator running at 32kHz, and the internal oscillator running at 667MHz, that would be

Re: Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-31 Thread maxime.ripard
On Wed, Jul 31, 2013 at 08:10:32PM +0800, kevin.z.m wrote: How does one select either the internal or the external 32kHz oscillator? Is this done in software (I can't find any reference to that in the user manuals) or in hardware? For A20, it should be in the Timer module, and there is a

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-30 Thread Emilio López
Hi Maxime, Overall this looks good to me, but I have some small comments: El 30/07/13 11:44, Maxime Ripard escribió: > Now that the clock driver has support for the A31 clocks, we can add > them to the DTSI and start using them in the relevant hardware blocks. > > Signed-off-by: Maxime Ripard

[PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-30 Thread Maxime Ripard
Now that the clock driver has support for the A31 clocks, we can add them to the DTSI and start using them in the relevant hardware blocks. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun6i-a31.dtsi | 137 --- 1 file changed, 127 insertions(+), 10

[PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-30 Thread Maxime Ripard
Now that the clock driver has support for the A31 clocks, we can add them to the DTSI and start using them in the relevant hardware blocks. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 137 --- 1 file

Re: [PATCH 4/4] ARM: sun6i: Enable clock support in the DTSI

2013-07-30 Thread Emilio López
Hi Maxime, Overall this looks good to me, but I have some small comments: El 30/07/13 11:44, Maxime Ripard escribió: Now that the clock driver has support for the A31 clocks, we can add them to the DTSI and start using them in the relevant hardware blocks. Signed-off-by: Maxime Ripard