Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Stephen Warren
On 07/11/2015 01:51 AM, Thomas Gleixner wrote: > On Fri, 10 Jul 2015, Stephen Warren wrote: >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >>> +static struct arm_local_intc intc __read_mostly; >> >> It'd be nice to give everything (types, functions, variables) a >> consistent symbol prefix;

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This interrupt controller is the new root interrupt controller with >> the timer, PMU events, and IPIs, and the bcm2835's interrupt >> controller is chained off of it to handle the peripherals. >> >> SMP IPI support was

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Thomas Gleixner writes: > On Fri, 10 Jul 2015, Stephen Warren wrote: >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >> > +static void bcm2836_mask_per_cpu_irq(unsigned int reg, unsigned int bit) >> > +{ >> > + void __iomem *reg_base = intc.base + reg; >> > + unsigned int i; >> > + >> > + for

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Stephen Warren
On 07/11/2015 01:51 AM, Thomas Gleixner wrote: On Fri, 10 Jul 2015, Stephen Warren wrote: On 07/07/2015 03:13 PM, Eric Anholt wrote: +static struct arm_local_intc intc __read_mostly; It'd be nice to give everything (types, functions, variables) a consistent symbol prefix;

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Stephen Warren swar...@wwwdotorg.org writes: On 07/07/2015 03:13 PM, Eric Anholt wrote: This interrupt controller is the new root interrupt controller with the timer, PMU events, and IPIs, and the bcm2835's interrupt controller is chained off of it to handle the peripherals. SMP IPI

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Thomas Gleixner t...@linutronix.de writes: On Fri, 10 Jul 2015, Stephen Warren wrote: On 07/07/2015 03:13 PM, Eric Anholt wrote: +static void bcm2836_mask_per_cpu_irq(unsigned int reg, unsigned int bit) +{ + void __iomem *reg_base = intc.base + reg; + unsigned int i; + + for (i =

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-11 Thread Thomas Gleixner
On Fri, 10 Jul 2015, Stephen Warren wrote: > On 07/07/2015 03:13 PM, Eric Anholt wrote: > > +static struct arm_local_intc intc __read_mostly; > > It'd be nice to give everything (types, functions, variables) a > consistent symbol prefix; bcm2836_arm_irqchip_ sounds like a good > bikeshed to me,

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-11 Thread Stephen Warren
On 07/07/2015 03:13 PM, Eric Anholt wrote: > This interrupt controller is the new root interrupt controller with > the timer, PMU events, and IPIs, and the bcm2835's interrupt > controller is chained off of it to handle the peripherals. > > SMP IPI support was mostly written by Andrea Merello,

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-11 Thread Stephen Warren
On 07/07/2015 03:13 PM, Eric Anholt wrote: This interrupt controller is the new root interrupt controller with the timer, PMU events, and IPIs, and the bcm2835's interrupt controller is chained off of it to handle the peripherals. SMP IPI support was mostly written by Andrea Merello, while I

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-11 Thread Thomas Gleixner
On Fri, 10 Jul 2015, Stephen Warren wrote: On 07/07/2015 03:13 PM, Eric Anholt wrote: +static struct arm_local_intc intc __read_mostly; It'd be nice to give everything (types, functions, variables) a consistent symbol prefix; bcm2836_arm_irqchip_ sounds like a good bikeshed to me, but

[PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-07 Thread Eric Anholt
This interrupt controller is the new root interrupt controller with the timer, PMU events, and IPIs, and the bcm2835's interrupt controller is chained off of it to handle the peripherals. SMP IPI support was mostly written by Andrea Merello, while I wrote most of the rest of the IRQ handling.

[PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-07 Thread Eric Anholt
This interrupt controller is the new root interrupt controller with the timer, PMU events, and IPIs, and the bcm2835's interrupt controller is chained off of it to handle the peripherals. SMP IPI support was mostly written by Andrea Merello, while I wrote most of the rest of the IRQ handling.