Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-16 Thread John Johansen
On 6/15/20 10:44 AM, Mimi Zohar wrote: > (Cc'ing John) > > On Mon, 2020-06-15 at 10:33 -0700, Casey Schaufler wrote: >> On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: >>> On 6/15/20 4:57 AM, Stephen Smalley wrote: >>> >>> Hi Stephen, >>> >>> Thanks for reviewing the patches. >>> > +void

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Mimi Zohar
On Mon, 2020-06-15 at 16:18 -0700, Casey Schaufler wrote: > On 6/15/2020 10:44 AM, Mimi Zohar wrote: > > (Cc'ing John) > > > > On Mon, 2020-06-15 at 10:33 -0700, Casey Schaufler wrote: > >> On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: > >>> On 6/15/20 4:57 AM, Stephen Smalley wrote: > >>>

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Casey Schaufler
On 6/15/2020 10:44 AM, Mimi Zohar wrote: > (Cc'ing John) > > On Mon, 2020-06-15 at 10:33 -0700, Casey Schaufler wrote: >> On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: >>> On 6/15/20 4:57 AM, Stephen Smalley wrote: >>> >>> Hi Stephen, >>> >>> Thanks for reviewing the patches. >>> >

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Stephen Smalley
On Mon, Jun 15, 2020 at 12:45 PM Lakshmi Ramasubramanian wrote: > > On 6/15/20 4:57 AM, Stephen Smalley wrote: > > I think I mentioned this on a previous version of these patches, but I > > would recommend including more than just the enabled and enforcing > > states in your measurement. Other

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Mimi Zohar
(Cc'ing John) On Mon, 2020-06-15 at 10:33 -0700, Casey Schaufler wrote: > On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: > > On 6/15/20 4:57 AM, Stephen Smalley wrote: > > > > Hi Stephen, > > > > Thanks for reviewing the patches. > > > >>> +void security_state_change(char *lsm_name, void

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Casey Schaufler
On 6/15/2020 9:45 AM, Lakshmi Ramasubramanian wrote: > On 6/15/20 4:57 AM, Stephen Smalley wrote: > > Hi Stephen, > > Thanks for reviewing the patches. > >>> +void security_state_change(char *lsm_name, void *state, int state_len) >>> +{ >>> +   ima_lsm_state(lsm_name, state, state_len); >>> +}

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Lakshmi Ramasubramanian
On 6/15/20 4:57 AM, Stephen Smalley wrote: Hi Stephen, Thanks for reviewing the patches. +void security_state_change(char *lsm_name, void *state, int state_len) +{ + ima_lsm_state(lsm_name, state, state_len); +} + What's the benefit of this trivial function instead of just calling

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Stephen Smalley
On Mon, Jun 15, 2020 at 7:57 AM Stephen Smalley wrote: > I think I mentioned this on a previous version of these patches, but I > would recommend including more than just the enabled and enforcing > states in your measurement. Other low-hanging fruit would be the > other selinux_state booleans

Re: [PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-15 Thread Stephen Smalley
On Fri, Jun 12, 2020 at 10:42 PM Lakshmi Ramasubramanian wrote: > > SELinux needs to implement the interface function, security_state(), for > the LSM to gather SELinux data for measuring. Define the security_state() > function in SELinux. > > The security modules should be able to notify the LSM

[PATCH 4/5] LSM: Define SELinux function to measure security state

2020-06-12 Thread Lakshmi Ramasubramanian
SELinux needs to implement the interface function, security_state(), for the LSM to gather SELinux data for measuring. Define the security_state() function in SELinux. The security modules should be able to notify the LSM when there is a change in the module's data. Define a function namely