Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-11 Thread David Howells
Dmitry Kasatkin wrote: > sign-file.c produce lots of annoying noise. Compiling it manually with -Wformat-security found those problems you listed and add -W found yet another problem. Differential patch attached. I've folded it into the patch that adds sign-file.c. David --- diff --git

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-11 Thread David Howells
Dmitry Kasatkin d.kasat...@samsung.com wrote: sign-file.c produce lots of annoying noise. Compiling it manually with -Wformat-security found those problems you listed and add -W found yet another problem. Differential patch attached. I've folded it into the patch that adds sign-file.c. David

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
On 05/12/14 16:04, David Howells wrote: > Dmitry Kasatkin wrote: > >> With just "make all" on Ubuntu. > What gcc? I don't see any warnings. > > David > $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Target: x86_64-linux-gnu

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread David Howells
Dmitry Kasatkin wrote: > With just "make all" on Ubuntu. What gcc? I don't see any warnings. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
On 05/12/14 12:23, David Howells wrote: > Dmitry Kasatkin wrote: > >> sign-file.c produce lots of annoying noise. > How did you get it to produce that? > > David > With just "make all" on Ubuntu. - Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread David Howells
Dmitry Kasatkin wrote: > sign-file.c produce lots of annoying noise. How did you get it to produce that? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
Hi David, sign-file.c produce lots of annoying noise. scripts/sign-file.c:153:2: warning: format not a string literal and no format arguments [-Wformat-security] ERR(!bd, dest_name); ^ scripts/sign-file.c:179:3: warning: format not a string literal and no format arguments [-Wformat-security]

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
Hi David, sign-file.c produce lots of annoying noise. scripts/sign-file.c:153:2: warning: format not a string literal and no format arguments [-Wformat-security] ERR(!bd, dest_name); ^ scripts/sign-file.c:179:3: warning: format not a string literal and no format arguments [-Wformat-security]

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread David Howells
Dmitry Kasatkin d.kasat...@samsung.com wrote: sign-file.c produce lots of annoying noise. How did you get it to produce that? David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
On 05/12/14 12:23, David Howells wrote: Dmitry Kasatkin d.kasat...@samsung.com wrote: sign-file.c produce lots of annoying noise. How did you get it to produce that? David With just make all on Ubuntu. - Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread David Howells
Dmitry Kasatkin d.kasat...@samsung.com wrote: With just make all on Ubuntu. What gcc? I don't see any warnings. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-12-05 Thread Dmitry Kasatkin
On 05/12/14 16:04, David Howells wrote: Dmitry Kasatkin d.kasat...@samsung.com wrote: With just make all on Ubuntu. What gcc? I don't see any warnings. David $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Target:

[PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-11-26 Thread David Howells
Provide a utility that: (1) Digests a module using the specified hash algorithm (typically sha256). [The digest can be dumped into a file by passing the '-d' flag] (2) Generates a PKCS#7 message that: (a) Has detached data (ie. the module content). (b) Is signed with the

[PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #2]

2014-11-26 Thread David Howells
Provide a utility that: (1) Digests a module using the specified hash algorithm (typically sha256). [The digest can be dumped into a file by passing the '-d' flag] (2) Generates a PKCS#7 message that: (a) Has detached data (ie. the module content). (b) Is signed with the