Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h

2021-04-13 Thread Helge Deller
On 4/13/21 5:46 PM, Christoph Hellwig wrote: On Tue, Apr 13, 2021 at 05:43:18PM +0200, Helge Deller wrote: On 4/12/21 10:55 AM, Christoph Hellwig wrote: The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for 32-bit syscall APIs, but we also need them for compat handling on 64-bit

Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h

2021-04-13 Thread Christoph Hellwig
On Tue, Apr 13, 2021 at 05:43:18PM +0200, Helge Deller wrote: > On 4/12/21 10:55 AM, Christoph Hellwig wrote: >> The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for >> 32-bit syscall APIs, but we also need them for compat handling on 64-bit >> kernels. > > Ok. > >> Given that

Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h

2021-04-13 Thread Helge Deller
On 4/12/21 10:55 AM, Christoph Hellwig wrote: The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for 32-bit syscall APIs, but we also need them for compat handling on 64-bit kernels. Ok. Given that redefining them is rather error prone, as shown by parisc getting the opcodes

[PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h

2021-04-12 Thread Christoph Hellwig
The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for 32-bit syscall APIs, but we also need them for compat handling on 64-bit kernels. Given that redefining them is rather error prone, as shown by parisc getting the opcodes wrong currently, just use the existing definitions for