Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write

2020-12-05 Thread Pierre-Louis Bossart
-static int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value) +int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value) { return sdw_nwrite_no_pm(slave, addr, 1, ); } +EXPORT_SYMBOL(sdw_write_no_pm); Why not export this is patch 1..? yes, good point. I guess

Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write

2020-12-04 Thread Vinod Koul
On 03-12-20, 04:46, Bard Liao wrote: > sdw_update_slave_status will be invoked when a codec is attached, > and the codec driver will initialize the codec with regmap functions > while the codec device is pm_runtime suspended. > > regmap routines currently rely on regular SoundWire IO functions, >

[PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write

2020-12-03 Thread Bard Liao
sdw_update_slave_status will be invoked when a codec is attached, and the codec driver will initialize the codec with regmap functions while the codec device is pm_runtime suspended. regmap routines currently rely on regular SoundWire IO functions, which will call