Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-22 Thread Alexey Brodkin
Hi Peter, On Mon, 2015-06-15 at 17:48 +0200, Peter Zijlstra wrote: > On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > > From: Alexey Brodkin > > -ENOCHANGELOG > > > Cc: Peter Zijlstra > > Cc: Arnaldo Carvalho de Melo > > Signed-off-by: Alexey Brodkin > > Signed-off-by: Vineet

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-22 Thread Alexey Brodkin
Hi Peter, On Mon, 2015-06-15 at 17:48 +0200, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: From: Alexey Brodkin abrod...@synopsys.com -ENOCHANGELOG Cc: Peter Zijlstra pet...@infradead.org Cc: Arnaldo Carvalho de Melo a...@kernel.org

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-17 Thread Peter Zijlstra
On Wed, Jun 17, 2015 at 05:18:27PM +0530, Vineet Gupta wrote: > Turns out that it is possible to implement NMI on ARCv2 in a pretty > straightforward way. > > Our RTOS Guru, Chuck, told me off list, that instead of using CLRI / SETI, we > can > use SETI with different args which would keep the

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-17 Thread Vineet Gupta
On Tuesday 16 June 2015 02:37 PM, Peter Zijlstra wrote: > On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: >> > On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: >>> > > On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > >> + if (arc_pmu->has_interrupts) {

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-17 Thread Vineet Gupta
On Tuesday 16 June 2015 02:37 PM, Peter Zijlstra wrote: On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: + if (arc_pmu-has_interrupts) { +

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-17 Thread Peter Zijlstra
On Wed, Jun 17, 2015 at 05:18:27PM +0530, Vineet Gupta wrote: Turns out that it is possible to implement NMI on ARCv2 in a pretty straightforward way. Our RTOS Guru, Chuck, told me off list, that instead of using CLRI / SETI, we can use SETI with different args which would keep the

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-16 Thread Vineet Gupta
On Tuesday 16 June 2015 02:37 PM, Peter Zijlstra wrote: On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: > On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: > > On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > >> + if (arc_pmu->has_interrupts) { > >> +

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-16 Thread Peter Zijlstra
On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: > On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: > > On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > >> + if (arc_pmu->has_interrupts) { > >> + int irq = platform_get_irq(pdev, 0); > > Hmm, so you're

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-16 Thread Vineet Gupta
On Tuesday 16 June 2015 02:37 PM, Peter Zijlstra wrote: On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: + if (arc_pmu-has_interrupts) { + int

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-16 Thread Peter Zijlstra
On Tue, Jun 16, 2015 at 05:37:40AM +, Vineet Gupta wrote: On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: + if (arc_pmu-has_interrupts) { + int irq = platform_get_irq(pdev, 0); Hmm, so you're requesting a

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Vineet Gupta
On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: > On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: >> +if (arc_pmu->has_interrupts) { >> +int irq = platform_get_irq(pdev, 0); > Hmm, so you're requesting a regular interrupt. > > I see your architecture has IRQ

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > + if (arc_pmu->has_interrupts) { > + int irq = platform_get_irq(pdev, 0); Hmm, so you're requesting a regular interrupt. I see your architecture has IRQ priorities, could you play games and create NMIs using those?

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: > From: Alexey Brodkin -ENOCHANGELOG > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Signed-off-by: Alexey Brodkin > Signed-off-by: Vineet Gupta > --- > struct arc_pmu { > struct pmu pmu; > + int

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: From: Alexey Brodkin abrod...@synopsys.com -ENOCHANGELOG Cc: Peter Zijlstra pet...@infradead.org Cc: Arnaldo Carvalho de Melo a...@kernel.org Signed-off-by: Alexey Brodkin abrod...@synopsys.com Signed-off-by: Vineet Gupta

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Vineet Gupta
On Monday 15 June 2015 09:55 PM, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: +if (arc_pmu-has_interrupts) { +int irq = platform_get_irq(pdev, 0); Hmm, so you're requesting a regular interrupt. I see your architecture has IRQ priorities,

Re: [PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-15 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:49:28PM +0530, Vineet Gupta wrote: + if (arc_pmu-has_interrupts) { + int irq = platform_get_irq(pdev, 0); Hmm, so you're requesting a regular interrupt. I see your architecture has IRQ priorities, could you play games and create NMIs using those? For

[PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-09 Thread Vineet Gupta
From: Alexey Brodkin Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Signed-off-by: Alexey Brodkin Signed-off-by: Vineet Gupta --- arch/arc/include/asm/perf_event.h | 8 ++- arch/arc/kernel/perf_event.c | 123 -- 2 files changed, 124 insertions(+),

[PATCH 4/8] ARCv2: perf: Support sampling events using overflow interrupts

2015-06-09 Thread Vineet Gupta
From: Alexey Brodkin abrod...@synopsys.com Cc: Peter Zijlstra pet...@infradead.org Cc: Arnaldo Carvalho de Melo a...@kernel.org Signed-off-by: Alexey Brodkin abrod...@synopsys.com Signed-off-by: Vineet Gupta vgu...@synopsys.com --- arch/arc/include/asm/perf_event.h | 8 ++-