Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat : > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat : > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Wed, Mar 21, 2018 at 10:15:51PM -0700, Srivatsa S. Bhat wrote: > On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > > On 3/21/18 7:02 PM, Steve French wrote: > >> Found a patch which solves the dependency issue. In my testing (on > >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Wed, Mar 21, 2018 at 10:15:51PM -0700, Srivatsa S. Bhat wrote: > On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > > On 3/21/18 7:02 PM, Steve French wrote: > >> Found a patch which solves the dependency issue. In my testing (on > >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that it

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/21/18 10:12 PM, Srivatsa S. Bhat wrote: > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that it

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/21/18 7:02 PM, Steve French wrote: > Found a patch which solves the dependency issue. In my testing (on > 4.9, with Windows 2016, and also to Samba) as Pavel suggested this > appears to fix the problem, but I will let Srivatsa confirm that it > also fixes it for him. The two attached

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/21/18 7:02 PM, Steve French wrote: > Found a patch which solves the dependency issue. In my testing (on > 4.9, with Windows 2016, and also to Samba) as Pavel suggested this > appears to fix the problem, but I will let Srivatsa confirm that it > also fixes it for him. The two attached

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Found a patch which solves the dependency issue. In my testing (on 4.9, with Windows 2016, and also to Samba) as Pavel suggested this appears to fix the problem, but I will let Srivatsa confirm that it also fixes it for him. The two attached patches for 4.9 should work. As an aside which may

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Found a patch which solves the dependency issue. In my testing (on 4.9, with Windows 2016, and also to Samba) as Pavel suggested this appears to fix the problem, but I will let Srivatsa confirm that it also fixes it for him. The two attached patches for 4.9 should work. As an aside which may

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Mar 13, 2018 at 10:21:45AM -0500, Steve French wrote: > There will be a fix needed to correct an oops in calc_signature, > besides the easy patch (smb3 validate negotiate patch). Ok, I still have no idea how to parse this for a stable tree submission. So can someone please just send me a

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Mar 13, 2018 at 10:21:45AM -0500, Steve French wrote: > There will be a fix needed to correct an oops in calc_signature, > besides the easy patch (smb3 validate negotiate patch). Ok, I still have no idea how to parse this for a stable tree submission. So can someone please just send me a

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

There will be a fix needed to correct an oops in calc_signature, besides the easy patch (smb3 validate negotiate patch). On Tue, Mar 13, 2018 at 4:21 AM, Greg Kroah-Hartman wrote: > On Sun, Mar 11, 2018 at 07:37:55PM -0700, Steve French wrote: >> Just got a wireshark

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

There will be a fix needed to correct an oops in calc_signature, besides the easy patch (smb3 validate negotiate patch). On Tue, Mar 13, 2018 at 4:21 AM, Greg Kroah-Hartman wrote: > On Sun, Mar 11, 2018 at 07:37:55PM -0700, Steve French wrote: >> Just got a wireshark trace - this is a fairly

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Sun, Mar 11, 2018 at 07:37:55PM -0700, Steve French wrote: > Just got a wireshark trace - this is a fairly trivial issue (missing > the validate negotiate must be signed patch) - I had some trouble > getting this version of the kernel running (unrelated issue) and on > systems with access to

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Sun, Mar 11, 2018 at 07:37:55PM -0700, Steve French wrote: > Just got a wireshark trace - this is a fairly trivial issue (missing > the validate negotiate must be signed patch) - I had some trouble > getting this version of the kernel running (unrelated issue) and on > systems with access to

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Just got a wireshark trace - this is a fairly trivial issue (missing the validate negotiate must be signed patch) - I had some trouble getting this version of the kernel running (unrelated issue) and on systems with access to Windows 2016... On Tue, Feb 27, 2018 at 10:33 AM, Srivatsa S. Bhat

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Just got a wireshark trace - this is a fairly trivial issue (missing the validate negotiate must be signed patch) - I had some trouble getting this version of the kernel running (unrelated issue) and on systems with access to Windows 2016... On Tue, Feb 27, 2018 at 10:33 AM, Srivatsa S. Bhat

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/1/18 12:12 PM, Steve French wrote: > So far I haven't been able to reproduce this on the current 4.9 stable > tree with vers=3.0 or with default (vers=1.0 for these older kernels). > Maybe the problem also depends on the particular version of Windows that hosts the SMB shares? I'm using

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 3/1/18 12:12 PM, Steve French wrote: > So far I haven't been able to reproduce this on the current 4.9 stable > tree with vers=3.0 or with default (vers=1.0 for these older kernels). > Maybe the problem also depends on the particular version of Windows that hosts the SMB shares? I'm using

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

So far I haven't been able to reproduce this on the current 4.9 stable tree with vers=3.0 or with default (vers=1.0 for these older kernels). On Tue, Feb 27, 2018 at 11:56 AM, Steve French wrote: > This shouldn't be too hard to figure out if willing to backport a > slightly

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

So far I haven't been able to reproduce this on the current 4.9 stable tree with vers=3.0 or with default (vers=1.0 for these older kernels). On Tue, Feb 27, 2018 at 11:56 AM, Steve French wrote: > This shouldn't be too hard to figure out if willing to backport a > slightly larger set of fixes

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 9:56 AM, Steve French wrote: > This shouldn't be too hard to figure out if willing to backport a > slightly larger set of fixes to the older stable, but I don't have a > system running 4.9 stable. > If you have the proposed patches that apply on 4.9, I'd be happy to try them out! [ I

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 9:56 AM, Steve French wrote: > This shouldn't be too hard to figure out if willing to backport a > slightly larger set of fixes to the older stable, but I don't have a > system running 4.9 stable. > If you have the proposed patches that apply on 4.9, I'd be happy to try them out! [ I

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

This shouldn't be too hard to figure out if willing to backport a slightly larger set of fixes to the older stable, but I don't have a system running 4.9 stable. Is this the correct stable tree branch? https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?h=linux-4.9.y On

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

This shouldn't be too hard to figure out if willing to backport a slightly larger set of fixes to the older stable, but I don't have a system running 4.9 stable. Is this the correct stable tree branch? https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?h=linux-4.9.y On

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 4:40 AM, Greg Kroah-Hartman wrote: > On Tue, Feb 27, 2018 at 01:22:31AM -0800, Srivatsa S. Bhat wrote: >> On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: >>> On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 4:40 AM, Greg Kroah-Hartman wrote: > On Tue, Feb 27, 2018 at 01:22:31AM -0800, Srivatsa S. Bhat wrote: >> On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: >>> On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Feb 27, 2018 at 01:22:31AM -0800, Srivatsa S. Bhat wrote: > On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: > > On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: > >> On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > >>> On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > On

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Feb 27, 2018 at 01:22:31AM -0800, Srivatsa S. Bhat wrote: > On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: > > On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: > >> On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > >>> On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > On

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: > On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: >> On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: >>> On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 2/27/18 12:54 AM, Greg Kroah-Hartman wrote: > On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: >> On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: >>> On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: > On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: >

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Mon, Feb 26, 2018 at 07:44:28PM -0800, Srivatsa S. Bhat wrote: > On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: >

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Hi Aurélien, On 1/19/18 5:23 AM, Aurélien Aptel wrote: > Hi, > > "Srivatsa S. Bhat" writes: >>> Any thoughts on what is the right fix for stable kernels? Mounting SMB3 >>> shares works great on mainline (v4.15-rc5). It also works on 4.4.109 if >>> I pass the sec=ntlmsspi

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Hi Aurélien, On 1/19/18 5:23 AM, Aurélien Aptel wrote: > Hi, > > "Srivatsa S. Bhat" writes: >>> Any thoughts on what is the right fix for stable kernels? Mounting SMB3 >>> shares works great on mainline (v4.15-rc5). It also works on 4.4.109 if >>> I pass the sec=ntlmsspi option to the mount

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Hi, "Srivatsa S. Bhat" writes: >> Any thoughts on what is the right fix for stable kernels? Mounting SMB3 >> shares works great on mainline (v4.15-rc5). It also works on 4.4.109 if >> I pass the sec=ntlmsspi option to the mount command (as opposed to the >> default:

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Hi, "Srivatsa S. Bhat" writes: >> Any thoughts on what is the right fix for stable kernels? Mounting SMB3 >> shares works great on mainline (v4.15-rc5). It also works on 4.4.109 if >> I pass the sec=ntlmsspi option to the mount command (as opposed to the >> default: sec=ntlmssp). Please let me

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 1/3/18 6:15 PM, Srivatsa S. Bhat wrote: > On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: >> On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >>> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: >>> 4.13-stable review patch. If anyone has any objections, please let me know. >>> >>> -- >>> >>> From: Steve

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On 11/1/17 8:18 AM, Greg Kroah-Hartman wrote: > On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: >> Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: >>> 4.13-stable review patch. If anyone has any objections, please let me know. >>> >>> -- >>> >>> From: Steve

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Steve French > > > > commit

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Steve French > > > > commit

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Steve French > > > > commit

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

On Tue, Oct 31, 2017 at 03:02:11PM +0200, Thomas Backlund wrote: > Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: > > 4.13-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Steve French > > > > commit

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me know. -- From: Steve French commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. According to MS-SMB2 3.2.55 validate_negotiate

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

Den 31.10.2017 kl. 11:55, skrev Greg Kroah-Hartman: 4.13-stable review patch. If anyone has any objections, please let me know. -- From: Steve French commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. According to MS-SMB2 3.2.55 validate_negotiate request must always

[PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

4.13-stable review patch. If anyone has any objections, please let me know. -- From: Steve French commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. According to MS-SMB2 3.2.55 validate_negotiate request must always be signed. Some Windows can fail

[PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

4.13-stable review patch. If anyone has any objections, please let me know. -- From: Steve French commit 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd upstream. According to MS-SMB2 3.2.55 validate_negotiate request must always be signed. Some Windows can fail the request if you