Re: [PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-19 Thread Andy Lutomirski
On Thu, Jun 19, 2014 at 3:46 PM, H. Peter Anvin wrote: > On 06/18/2014 03:59 PM, Andy Lutomirski wrote: >> >> This may break make vdso_install with binutils before 2.17.50.0.17. >> On the other hand, make vdso_install was probably never useful with >> earlier binutils, since the installed files

Re: [PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-19 Thread H. Peter Anvin
On 06/18/2014 03:59 PM, Andy Lutomirski wrote: > > This may break make vdso_install with binutils before 2.17.50.0.17. > On the other hand, make vdso_install was probably never useful with > earlier binutils, since the installed files are AFAIK completely > useless without build-id. > How does

Re: [PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-19 Thread H. Peter Anvin
On 06/18/2014 03:59 PM, Andy Lutomirski wrote: This may break make vdso_install with binutils before 2.17.50.0.17. On the other hand, make vdso_install was probably never useful with earlier binutils, since the installed files are AFAIK completely useless without build-id. How does it

Re: [PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-19 Thread Andy Lutomirski
On Thu, Jun 19, 2014 at 3:46 PM, H. Peter Anvin h...@zytor.com wrote: On 06/18/2014 03:59 PM, Andy Lutomirski wrote: This may break make vdso_install with binutils before 2.17.50.0.17. On the other hand, make vdso_install was probably never useful with earlier binutils, since the installed

[PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-18 Thread Andy Lutomirski
With this change, doing 'make vdso_install' and telling gdb: set debug-file-directory /lib/modules/KVER/vdso will enable vdso debugging with symbols. This is useful for testing, but kernel RPM builds will probably want to manually delete these symlinks or otherwise do something sensible when

[PATCH 5/5] x86,vdso: Create .build-id links for unstripped vdso files

2014-06-18 Thread Andy Lutomirski
With this change, doing 'make vdso_install' and telling gdb: set debug-file-directory /lib/modules/KVER/vdso will enable vdso debugging with symbols. This is useful for testing, but kernel RPM builds will probably want to manually delete these symlinks or otherwise do something sensible when